1367851 - Memory monitor only works while GeckoActivity-based activities are alive

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, enhancement)

Description

[Jan Henning [:JanH]]

At the moment Android's low memory notifications are forwarded to the memory monitor via GeckoActivity.
This means that if multiple GeckoActivities are alive (e.g. BrowserApp and one of the web app/custom tab activities), the MemoryMonitor receives the same low memory notification from each activity in turn. While this isn't a problem per se, as the MemoryMonitor handles this fine, it's still not the most elegant procedure.

It also means that if no GeckoActivity is active (e.g. we're displaying our preferences and BrowserApp has been killed off after being paused - can be forced by enabling "Don't keep activities"), we don't receive any low memory notifications.

As of API14, we can use "registerComponentCallbacks" to receive app-wide notifications about these things instead.

Comment 1

[Jan Henning [:JanH]]

Attachment: Bug 1367851 - Use ComponentCallbacks to listen for low memory notifications.

At the moment, we forward these from GeckoActivity, which means that they won't work if no GeckoActivity-based activity is active (can happen within our settings for example).

As of API14, we can now register an app-wide ComponentCallbacks(2) class, allowing us to easily receive low memory notifications no matter which activity is currently alive.

Review commit: https://reviewboard.mozilla.org/r/142858/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/142858/

Comment 2

[Andrzej Hunt :ahunt]

Comment on attachment 8871393 [details]
Bug 1367851 - Use ComponentCallbacks to listen for low memory notifications.

https://reviewboard.mozilla.org/r/142858/#review148000

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9baa6614a0ba
Use ComponentCallbacks to listen for low memory notifications. r=ahunt

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9baa6614a0ba