Closed Bug 1367851 Opened 2 years ago Closed 2 years ago

Memory monitor only works while GeckoActivity-based activities are alive

Categories

(Firefox for Android :: General, enhancement)

All
Android
enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: JanH, Assigned: JanH)

Details

Attachments

(1 file)

At the moment Android's low memory notifications are forwarded to the memory monitor via GeckoActivity.
This means that if multiple GeckoActivities are alive (e.g. BrowserApp and one of the web app/custom tab activities), the MemoryMonitor receives the same low memory notification from each activity in turn. While this isn't a problem per se, as the MemoryMonitor handles this fine, it's still not the most elegant procedure.

It also means that if no GeckoActivity is active (e.g. we're displaying our preferences and BrowserApp has been killed off after being paused - can be forced by enabling "Don't keep activities"), we don't receive any low memory notifications.

As of API14, we can use "registerComponentCallbacks" to receive app-wide notifications about these things instead.
Comment on attachment 8871393 [details]
Bug 1367851 - Use ComponentCallbacks to listen for low memory notifications.

https://reviewboard.mozilla.org/r/142858/#review148000
Attachment #8871393 - Flags: review+
Pushed by mozilla@buttercookie.de:
https://hg.mozilla.org/integration/autoland/rev/9baa6614a0ba
Use ComponentCallbacks to listen for low memory notifications. r=ahunt
https://hg.mozilla.org/mozilla-central/rev/9baa6614a0ba
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Attachment #8871393 - Flags: review?(andrzej)
You need to log in before you can comment on or make changes to this bug.