Closed Bug 1367852 Opened 3 years ago Closed 3 years ago

Not dumping symbols for gtest xul.dll

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: ted, Assigned: chmanchester)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

We aren't getting symbols in gtest crash stacks on Windows. I poked around build logs, and it looks like we're not actually dumping symbols from the gtest xul.dll. For some reason we set an alternate PDB filename there:
https://dxr.mozilla.org/mozilla-central/rev/f81bcc23d37d7bec48f08b19a9327e93c54d37b5/toolkit/library/gtest/Makefile.in#32

That breaks the `ShouldProcess` check here now that we're passing the DLL filename to symbolstore.py instead of letting it find PDB files:
https://dxr.mozilla.org/mozilla-central/rev/f81bcc23d37d7bec48f08b19a9327e93c54d37b5/toolkit/crashreporter/tools/symbolstore.py#591
Blocks: 1367848
Assignee: nobody → cmanchester
Comment on attachment 8871493 [details]
Bug 1367852 - Fix symbol dumping for gtest xul.dll

https://reviewboard.mozilla.org/r/142956/#review146910

I'm happy the simple fix worked!
Attachment #8871493 - Flags: review?(ted) → review+
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8b0e09b6cf8e
Fix symbol dumping for gtest xul.dll r=ted
Comment on attachment 8872737 [details]
Bug 1367852 - Defer file read to reduce peak memory use in mozjar when dumping symbols.

https://reviewboard.mozilla.org/r/144264/#review148040
Attachment #8872737 - Flags: review?(ted) → review+
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/463ad37994b0
Defer file read to reduce peak memory use in mozjar when dumping symbols. r=ted
https://hg.mozilla.org/integration/autoland/rev/2c8b721cffdb
Fix symbol dumping for gtest xul.dll r=ted
https://hg.mozilla.org/mozilla-central/rev/463ad37994b0
https://hg.mozilla.org/mozilla-central/rev/2c8b721cffdb
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.