Closed
Bug 1367867
Opened 7 years ago
Closed 7 years ago
Improve the User Initial Labels so users immediately recognize what they are
Categories
(Tree Management :: Treeherder, enhancement, P5)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jfrench, Assigned: jfrench)
References
Details
Attachments
(1 file)
Trivial stuff, but perhaps it would be useful if the User Initial Label in the revision list wasn't just a plain grey box; but instead better communicated at a glance what it is. I'll put up a PR so folks can see the difference and consider it.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED
Comment 1•7 years ago
|
||
Attachment #8871413 -
Flags: feedback+
Assignee | ||
Comment 2•7 years ago
|
||
Comment on attachment 8871413 [details] [review] [treeherder] tojon:initial-label-updates > mozilla:master PR for review at your leisure :)
Attachment #8871413 -
Flags: review?(cdawson)
Assignee | ||
Comment 3•7 years ago
|
||
Comment on attachment 8871413 [details] [review] [treeherder] tojon:initial-label-updates > mozilla:master Actually I need to make one tweak.
Attachment #8871413 -
Flags: review?(cdawson)
Assignee | ||
Updated•7 years ago
|
Attachment #8871413 -
Flags: review?(cdawson)
Unsure if the second commit brings much to the table. Maybe if we had a list of most/all bot committers (servo's sync commits come to mind on autoland), we could apply this to all of them? But just the fxbuilds bot on its own seems not very helpful to me.
Assignee | ||
Comment 5•7 years ago
|
||
Ok, sounds good. I will pull that second commit for now.
Assignee | ||
Comment 6•7 years ago
|
||
In case anyone else wishes to +1 the fa request for a bot user icon, here it is https://github.com/FortAwesome/Font-Awesome/issues/519
Comment 7•7 years ago
|
||
Comment on attachment 8871413 [details] [review] [treeherder] tojon:initial-label-updates > mozilla:master Yikes, so sorry for the long delay on this. Looks cool, though. Thanks! :)
Attachment #8871413 -
Flags: review?(cdawson) → review+
Comment 8•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/c6dedb4af69081348aa27a1f515abd39e35b113b Bug 1367867 - Improve recognition of user Initial labels
Assignee | ||
Comment 9•7 years ago
|
||
Np, thanks :camd!
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•