Closed Bug 1367877 Opened 7 years ago Closed 7 years ago

Remove a few unused Frame IDs

Categories

(Core :: Layout, enhancement, P3)

Product:
Core
Component:
Layout
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)

References

Details

Attachments

(1 file)

Remove a few unused frame class IDs.
1.79 KB, patch
jfkthame
: review+
Details | Diff | Splinter Review 
      No description provided.
Comment on attachment 8871422 [details] [diff] [review]
Remove a few unused frame class IDs.

Review of attachment 8871422 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Do we need to do something to refresh the frame ID lists in servo/components/style/gecko/generated/*, or is that someone else's responsibility? Or handled automatically?
Attachment #8871422 - Flags: review?(jfkthame) → review+
(In reply to Jonathan Kew (:jfkthame) from comment #2)
> LGTM. Do we need to do something to refresh the frame ID lists in
> servo/components/style/gecko/generated/*, or is that someone else's
> responsibility? Or handled automatically?

No. Those files are automatically generated bindings for stylo, but they need to be manually check-in into servo/servo. People working on stylo will take care of that.
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/62f8db64e839
Remove a few unused frame class IDs.  r=jfkthame
https://hg.mozilla.org/mozilla-central/rev/62f8db64e839
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: