Remove a few unused Frame IDs

RESOLVED FIXED in Firefox 55

Status

()

Core
Layout
P3
normal
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: mats, Assigned: mats)

Tracking

Trunk
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

7 months ago
Created attachment 8871422 [details] [diff] [review]
Remove a few unused frame class IDs.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c983204eefa4dbe07249c1adc78fed554dd57a4d
Attachment #8871422 - Flags: review?(jfkthame)
Comment on attachment 8871422 [details] [diff] [review]
Remove a few unused frame class IDs.

Review of attachment 8871422 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Do we need to do something to refresh the frame ID lists in servo/components/style/gecko/generated/*, or is that someone else's responsibility? Or handled automatically?
Attachment #8871422 - Flags: review?(jfkthame) → review+
(In reply to Jonathan Kew (:jfkthame) from comment #2)
> LGTM. Do we need to do something to refresh the frame ID lists in
> servo/components/style/gecko/generated/*, or is that someone else's
> responsibility? Or handled automatically?

No. Those files are automatically generated bindings for stylo, but they need to be manually check-in into servo/servo. People working on stylo will take care of that.

Comment 4

7 months ago
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/62f8db64e839
Remove a few unused frame class IDs.  r=jfkthame

Comment 5

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/62f8db64e839
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.