Closed Bug 1367885 Opened 6 years ago Closed 6 years ago

Eliminate redundant QI from mscom::Interceptor constructor

Categories

(Core :: Disability Access APIs, enhancement)

Product:
Core
Component:
Disability Access APIs
Platform:
Unspecified
Windows
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: bugzilla, Assigned: bugzilla)

Details

Attachments

(1 file)

Interceptor init fast path
6.73 KB, patch
jimm
: review+
Details | Diff | Splinter Review 
When creating a new interceptor, we are given a target interface whose IID we already know.

The current interceptor implementation ignores this fact and goes off and does an extra QI to resolve the interface, even though we already have one!

I've written a patch that gives us a fast path for interceptor instantiation.
Attachment #8871431 - Flags: review?(jmathies) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc854def3953aed24632eb910aa568702d67a522
Bug 1367885: Follow-up - fix missing explicit keyword on constructor on a CLOSED TREE; r=bustage
https://hg.mozilla.org/integration/mozilla-inbound/rev/ab4ef8ca799e413049ff66c26328f409b15eb223
Bug 1367885: Backed out changeset 3f6e08c5233f for bc4 bustage on a CLOSED TREE; r=backout
Bugherder got confused because the backout only mentioned one of the commit hashes, so it thought the other one was enough to fix the bug.
Status: RESOLVED → REOPENED
status-firefox55: fixed → ---
Resolution: FIXED → ---
Target Milestone: mozilla55 → ---
https://hg.mozilla.org/mozilla-central/rev/09894b9ce473
Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
https://hg.mozilla.org/integration/mozilla-inbound/rev/6fd10955e89903caf8f92e2c600aa2aa4a2be496
Bug 1367885: Follow-up - remove code that mistakenly landed as part of commit 09894b9ce473; r=backout
You need to log in before you can comment on or make changes to this bug.