Closed Bug 1367895 Opened 4 years ago Closed 4 years ago
Ensure Photon-only tests are enabled past Nightly before uplift
I've started to spot tests that are Photon-specific. Here's one: https://hg.mozilla.org/mozilla-central/file/15688bfe56c9/browser/base/content/test/urlbar/browser_page_action_menu.js I only spotted this because I've started to do periodic merges from central to cedar with Photon disabled to ensure we've not accidentally broken things in the disabled state. I suspect we'll start to see more and more of these things as Photon ramps up. This is the sort of thing that can burn us in a silly way if we're not careful - we need to ensure that these tests get enabled _past_ Nightly once we're sure Photon is ready to be uplifted and enabled by default on Beta. Perhaps that means disabling tests with a photon_build thing instead of nightly_build.
4 years ago
Depends on: 1366555
[Tracking Requested - why for this release]: We need to ensure that this happens before the 57 uplift to beta, or else we're going to risk missing out on some test coverage here.
https://dxr.mozilla.org/mozilla-central/search?q=path:browser/base/content/test%20nightly_build Looks like it's just those two tests? I can run them in my next uplift simulation and see what happens.
Looks good on the uplift simulations. Did some manifest tidying too since I'm OCD like that.
Assignee: nobody → ryanvm
Status: NEW → ASSIGNED
Attachment #8906870 - Flags: review?(mconley)
Comment on attachment 8906870 [details] [diff] [review] remove some obsolete annotations Review of attachment 8906870 [details] [diff] [review]: ----------------------------------------------------------------- If try is happy, then so am I! Thanks, RyanVM!
Attachment #8906870 - Flags: review?(mconley) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/247dc838b340 Remove some obsolete nightly_only & release_or_beta test manifest annotations. r=mconley
You need to log in before you can comment on or make changes to this bug.