Add information on GC trigger thresholds to profile JSON

RESOLVED FIXED in Firefox 56

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: sfink, Assigned: sfink)

Tracking

unspecified
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

2 years ago
It would be nice to be able to correlate GC speeds to memory utilization.
(Assignee)

Comment 1

2 years ago
Created attachment 8871452 [details] [diff] [review]
Record the values and thresholds for GC triggers

Sorry, the naming isn't great. Suggestions welcome.

Also, it would probably be a lot more interesting to capture the amount of free physical memory or something. But at least this will help in cases where we're repeatedly hitting an allocation trigger or something.
Attachment #8871452 - Flags: review?(jcoppeard)
(Assignee)

Comment 2

2 years ago
Created attachment 8871545 [details] [diff] [review]
Record the values and thresholds for GC triggers

Make it compile and add in malloc triggers.
Attachment #8871545 - Flags: review?(jcoppeard)
(Assignee)

Updated

2 years ago
Attachment #8871452 - Attachment is obsolete: true
Attachment #8871452 - Flags: review?(jcoppeard)
Comment on attachment 8871545 [details] [diff] [review]
Record the values and thresholds for GC triggers

Review of attachment 8871545 [details] [diff] [review]:
-----------------------------------------------------------------

Great, it will good to record this information.

::: js/src/jsgc.cpp
@@ +3010,2 @@
>          triggerZoneGC(zone, JS::gcreason::ALLOC_TRIGGER);
>      } else if (usedBytes >= igcThresholdBytes) {

We should move the recordTrigger call into triggerZoneGC since this happens in a few places.
Attachment #8871545 - Flags: review?(jcoppeard) → review+

Comment 4

2 years ago
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6ddd2bf5d55e
Record the values and thresholds for GC triggers, r=jonco

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6ddd2bf5d55e
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.