1367900 - Add information on GC trigger thresholds to profile JSON

Status: RESOLVED FIXED

(Core :: JavaScript: GC, enhancement)

Description

[Steve Fink [:sfink] [:s:]]

It would be nice to be able to correlate GC speeds to memory utilization.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Record the values and thresholds for GC triggers

Sorry, the naming isn't great. Suggestions welcome.

Also, it would probably be a lot more interesting to capture the amount of free physical memory or something. But at least this will help in cases where we're repeatedly hitting an allocation trigger or something.

Comment 2

[Steve Fink [:sfink] [:s:]]

Attachment: Record the values and thresholds for GC triggers

Make it compile and add in malloc triggers.

Comment 3

[Jon Coppeard (:jonco)]

Comment on attachment 8871545 [details] [diff] [review]
Record the values and thresholds for GC triggers

Review of attachment 8871545 [details] [diff] [review]:
-----------------------------------------------------------------

Great, it will good to record this information.

::: js/src/jsgc.cpp
@@ +3010,2 @@
>          triggerZoneGC(zone, JS::gcreason::ALLOC_TRIGGER);
>      } else if (usedBytes >= igcThresholdBytes) {

We should move the recordTrigger call into triggerZoneGC since this happens in a few places.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6ddd2bf5d55e
Record the values and thresholds for GC triggers, r=jonco

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6ddd2bf5d55e