Closed Bug 1367959 Opened 7 years ago Closed 7 years ago

Remove brandShortName from the string "… can improve &brandShortName; performance"

Categories

(Firefox :: Settings UI, enhancement, P1)

55 Branch
enhancement

Tracking

()

VERIFIED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed
firefox57 --- verified

People

(Reporter: evanxd, Assigned: evanxd)

References

Details

(Whiteboard: [photon-preference])

Attachments

(2 files)

Base Michelle's recommendation from [1], remove brandShortName from the string "… can improve &brandShortName; performance". And this is the spec[1].

[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=1364070#c17
[2]: https://mozilla.invisionapp.com/share/C2B97CAYH#/screens/230367021
Flags: qe-verify+
Attachment #8871583 - Flags: review?(jaws)
Hi Jared,

Could you help review the patch?

Michelle suggest us to update the string at https://bugzilla.mozilla.org/show_bug.cgi?id=1364070#c17.

Thanks.
Comment on attachment 8871583 [details]
Bug 1367959 - Remove brandShortName from the string "… can improve &brandShortName; performance".

https://reviewboard.mozilla.org/r/143066/#review146770

::: browser/locales/en-US/chrome/browser/preferences-old/advanced.dtd:134
(Diff revision 1)
>                                           "Use recommended performance settings">
>  <!ENTITY useRecommendedPerformanceSettings.description
>                                           "These settings are tailored to your computer’s hardware and operating system.">
>  <!ENTITY useRecommendedPerformanceSettings.accesskey
>                                           "U">
> -<!ENTITY limitContentProcess.label       "Content process limit">
> +<!ENTITY limitContentProcess2.label       "Content process limit">

I've noticed this in the previous patch: if the string doesn't change, you shouldn't change the ID just to match the others, it creates unnecessary churn for localizers. The only exception is if you change a .label, then the .accesskey should match.

But… since this has already become a big mess with old and new prefs (they're completely out of sync), I would rename them to something more useful, e.g. limitContentProcessOption.(label|description|accesskey) and sync both old and new prefs.

And, for the future, avoid them going out of sync like this.
Thanks for reminding, Francesco. I've update the patch to sync the old andnew prefs.
Whiteboard: [photon-preference][triage] → [photon-preference]
Comment on attachment 8871583 [details]
Bug 1367959 - Remove brandShortName from the string "… can improve &brandShortName; performance".

https://reviewboard.mozilla.org/r/143066/#review146958
Attachment #8871583 - Flags: review?(jaws) → review+
Thanks for reviewing, Jared. Let's land the patch.
Keywords: checkin-needed
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 81ec88533854 -d 3a1143c269e5: rebasing 398492:81ec88533854 "Bug 1367959 - Remove brandShortName from the string "… can improve &brandShortName; performance". r=jaws" (tip)
merging browser/components/preferences/in-content-old/main.xul
merging browser/locales/en-US/chrome/browser/preferences-old/advanced.dtd
warning: conflicts while merging browser/locales/en-US/chrome/browser/preferences-old/advanced.dtd! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Rebased. Let's do again.
Keywords: checkin-needed
Pushed by philringnalda@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/84e9dbe2e9e3
Remove brandShortName from the string "… can improve &brandShortName; performance". r=jaws
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/84e9dbe2e9e3
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Hi Evan,
Can you please provide some steps(if any) or additional information, in order for QA to verify this issue?
Thank you.
Flags: needinfo?(evan)
Attached image bug-1367959.png
Hi Deac,

The bug is about a string change. You could just verify the string change in the red box of the attachment screenshot. And this is the spec[1] for the string change.

Thank you.

[1]: https://mozilla.invisionapp.com/share/C2B97CAYH#/screens/230367021
Flags: needinfo?(evan)
Build ID: 20170810100255
User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:57.0) Gecko/20100101 Firefox/57.0

Verified as fixed on Firefox Nightly 57.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: