Closed
Bug 1367983
Opened 7 years ago
Closed 7 years ago
Use more appropriate way to decide whether need to release decoder resource
Categories
(Firefox for Android Graveyard :: Audio/Video, defect, P3)
Firefox for Android Graveyard
Audio/Video
Tracking
(firefox57 fixed)
RESOLVED
FIXED
Firefox 56
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: alwu, Assigned: alwu)
References
Details
Attachments
(1 file)
In bug1367980, we always use the same decoder even the decoding ended. However, we could use more appropriate way to detect whether need to release the decoder. eg. if video is looping, we could use same decoder, otherwise, release the resource. Also need to add ref-test to avoid regression.
Comment 1•7 years ago
|
||
(In reply to Alastor Wu [:alwu][please needinfo? me][7/26-8/3 PTO] from comment #0) > In bug1367980, we always use the same decoder even the decoding ended. > > However, we could use more appropriate way to detect whether need to release > the decoder. eg. if video is looping, we could use same decoder, otherwise, > release the resource. JW, IIRC, you fixed a similar bug like this, right?
Flags: needinfo?(jwwang)
Priority: -- → P3
Assignee | ||
Comment 2•7 years ago
|
||
I'll revert the change in bug1367980, because JW has already done what I want to implement in bug1371202.
Flags: needinfo?(jwwang)
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=05b67c2e8a4110b5e19af19d0b2e4bdfe31b5af1
Comment hidden (mozreview-request) |
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8887393 [details] Bug 1367983 - correct comment. https://reviewboard.mozilla.org/r/158244/#review165554
Attachment #8887393 -
Flags: review?(jwwang) → review+
Pushed by alwu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/42667c5ba946 revert the change of bug1367980. r=jwwang
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/42667c5ba946
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Comment 9•7 years ago
|
||
backed out on request in https://bugzilla.mozilla.org/show_bug.cgi?id=1383673#c3
Comment 10•7 years ago
|
||
Backout by cbook@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/a2058025fd77 Backed out changeset 42667c5ba946 for causing bug 1383673
Comment hidden (mozreview-request) |
Assignee | ||
Comment 12•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8a52d7a309b80f7c7aba073acef735641a3f5fb9
Comment 13•7 years ago
|
||
Pushed by alwu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/629a306d41e0 correct comment. r=jwwang
Comment 14•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/629a306d41e0
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•