Closed Bug 1367983 Opened 3 years ago Closed 3 years ago

Use more appropriate way to decide whether need to release decoder resource

Categories

(Firefox for Android :: Audio/Video, defect, P3)

defect

Tracking

()

RESOLVED FIXED
Firefox 56
Tracking Status
firefox57 --- fixed

People

(Reporter: alwu, Assigned: alwu)

References

Details

Attachments

(1 file)

59 bytes, text/x-review-board-request
jwwang
: review+
Details
In bug1367980, we always use the same decoder even the decoding ended.

However, we could use more appropriate way to detect whether need to release the decoder. eg. if video is looping, we could use same decoder, otherwise, release the resource.

Also need to add ref-test to avoid regression.
(In reply to Alastor Wu [:alwu][please needinfo? me][7/26-8/3 PTO] from comment #0)
> In bug1367980, we always use the same decoder even the decoding ended.
> 
> However, we could use more appropriate way to detect whether need to release
> the decoder. eg. if video is looping, we could use same decoder, otherwise,
> release the resource.
JW, 
IIRC, you fixed a similar bug like this, right?
Flags: needinfo?(jwwang)
Priority: -- → P3
I'll revert the change in bug1367980, because JW has already done what I want to implement in bug1371202.
Flags: needinfo?(jwwang)
Comment on attachment 8887393 [details]
Bug 1367983 - correct comment.

https://reviewboard.mozilla.org/r/158244/#review165554
Attachment #8887393 - Flags: review?(jwwang) → review+
https://hg.mozilla.org/mozilla-central/rev/42667c5ba946
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
backed out on request in https://bugzilla.mozilla.org/show_bug.cgi?id=1383673#c3
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Backout by cbook@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/a2058025fd77
Backed out changeset 42667c5ba946 for causing bug 1383673
https://hg.mozilla.org/mozilla-central/rev/629a306d41e0
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.