1368026 - [compare-locales] clean up observer logic in compare_locales.compare

Status: RESOLVED FIXED

(Localization Infrastructure and Tools :: compare-locales, enhancement)

Description

[Axel Hecht [:Pike]]

With the landings of bug 1361037, the different roles of observers for ContentComparer become more clear:

- some observers filter
- some observers just gather stats.

We should make the code look like that, too.

Comment 1

[Axel Hecht [:Pike]]

Attachment: bug 1368026, rename observers to observers and stat_observers,

The `observers` name is now internal to ContentComparer, and
passed in as unconditional list argument to the constructor.

What used to be other_observers is now stat_observers, and
an optional keyword argument.

Review commit: https://reviewboard.mozilla.org/r/143204/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/143204/

Comment 2

[Staś Małolepszy :stas]

Comment on attachment 8871710 [details]
bug 1368026, rename observers to observers and stat_observers,

https://reviewboard.mozilla.org/r/143204/#review147012

Yup, that makes sense!

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 8871710 [details]
bug 1368026, rename observers to observers and stat_observers,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/143204/diff/1-2/

Comment 4

[Axel Hecht [:Pike]]

Landed as https://hg.mozilla.org/l10n/compare-locales/rev/44f0db5abfab2873c8f17d8868647016d126283a, thanks.