Closed
Bug 1368051
Opened 7 years ago
Closed 7 years ago
add awsy, autophone rca2 and autophone geckoview tests to trychooser
Categories
(Release Engineering :: General, enhancement)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bkelly, Assigned: bc)
Details
Attachments
(2 files, 1 obsolete file)
51 bytes,
text/x-github-pull-request
|
Details | Review | |
5.54 KB,
patch
|
Details | Diff | Splinter Review |
We now have awsy running in automation, but it doesn't seem trychooser supports it yet.
It would also be nice if "all" try builds included it, but I don't know what the resource requirements are. Maybe its like talos?
Comment 1•7 years ago
|
||
:jmaher, could you redirect this to someone who would be able to fix this?
Flags: needinfo?(jmaher)
Comment 2•7 years ago
|
||
:bkelly, Which try syntax was used? Please note, we only run AWSY on linux and windows as those are VM's and we are not limited to hardware. We have considered making this scheduled via -t since it is more of a performance/measurement test, but that can be confusing.
:bc, is this something you could take on? I know we an get AWSY to run, but there are probably small nits to resolve.
Flags: needinfo?(jmaher) → needinfo?(bob)
Reporter | ||
Comment 3•7 years ago
|
||
Oh, it does run for "all" try builds. Sorry, I was confused.
Comment 4•7 years ago
|
||
IMO at the least "awsy" should be an individually selectable option, rather than requiring the user to specify "-u all" (for all I know it already is, in which case all we need to do is update the trychooser UI to reflect that)
Assignee | ||
Comment 5•7 years ago
|
||
We need support in https://mozilla-releng.net/trychooser/ and in mach try? I can take a look. Might be a day or two before I get to it.
Assignee: nobody → bob
Status: NEW → ASSIGNED
Flags: needinfo?(bob)
Comment 6•7 years ago
|
||
FYI according to erahm this syntax might already work:
"Yeah, not in trychooser yet but I think -u 'awsy-e10s' or 'sy-e10s' works."
https://twitter.com/eroc/status/868169500461367296
In which case this is just about making a small modification to the trychooser web ui.
Assignee | ||
Comment 7•7 years ago
|
||
Attachment #8873082 -
Flags: review?(rgarbas)
Assignee | ||
Comment 8•7 years ago
|
||
The pull request failed the checks due to "The AWS Access Key Id you provided does not exist in our records." errors.
Comment 9•7 years ago
|
||
odd; iirc github was having some issues earlier today, maybe it is still problematic
Assignee | ||
Comment 10•7 years ago
|
||
Comment on attachment 8873082 [details] [review]
PR 361
I'll cancel this request and bundle some additions for autophone.
Attachment #8873082 -
Flags: review?(rgarbas)
Assignee | ||
Updated•7 years ago
|
Attachment #8873082 -
Attachment is obsolete: true
Assignee | ||
Comment 11•7 years ago
|
||
I'm not sure what I'm doing wrong in doing the pull request, but it fails in the integration check.
This adds
* platform android-api-15-gradle
* AWSY test
* Autophone tests
** autophone-mochitest-geckoview-e10s
** autophone-robocoptest-autophone2
** autophone-s1s2geckoview
** autophone-s1s2geckoview-e10s
Assignee | ||
Comment 12•7 years ago
|
||
A patch matching the pull request.
gbarbas: What am I doing wrong with the PR?
Flags: needinfo?(rgarbas)
Assignee | ||
Updated•7 years ago
|
Summary: trychooser does not support awsy tests → add awsy, autophone rca2 and autophone geckoview tests to trychooser
Assignee | ||
Comment 13•7 years ago
|
||
regardless of my failure in getting the pr right, garbas reviewed, merged and today deployed the changes. Thanks!
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: needinfo?(rgarbas)
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•