1368060 - More prefs for controlling plugin infobars

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, enhancement, P1)

Description

[Benjamin Smedberg]

This bug adds two preferences and additional telemetry to help control plugin infobars:

#1 - a pref which can suppress infobars entirely

#2 - a pref which changes the behavior when a user dismisses an infobar using the "x" button and not the "continue blocking" button

Currently if a user chooses "continue blocking" we never show the infobar again for that site. But if a user chooses the "x" we keep showing the infobar on each visit/reload. This pref gives the "x" and "continue blocking" the same behavior to permanently suppress the infobar on that site.

In this bug neither of these will be given UI. We may eventually build UI for #1 (probably never have UI for #2).

The defaults will remain the same as current behavior: show infobars, and X is non-persistent.

Telemetry will record the value of these prefs in case users change them. It will also count infobar dismissals just as we currently count allow/block.

Comment 1

[Benjamin Smedberg]

Attachment: Bug 1368060 - Prefs and telemetry for hidden-plugin infobars. This patch does not change any defaults, but provides options which we'll test via A/B testing and telemetry to measure success. data-r?francois

Review commit: https://reviewboard.mozilla.org/r/143332/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/143332/

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8871836 [details]
Bug 1368060 - Prefs and telemetry for hidden-plugin infobars. This patch does not change any defaults, but provides options which we'll test via A/B testing and telemetry to measure success.  data-r?francois

https://reviewboard.mozilla.org/r/143332/#review147066

Looks like it'll work as advertised. Thanks!

::: toolkit/components/telemetry/Histograms.json:8097
(Diff revision 1)
> +  "PLUGINS_INFOBAR_DISMISSED": {
> +    "record_in_processes": ["main"],
> +    "releaseChannelCollection": "opt-out",
> +    "expires_in_version": "60",
> +    "kind": "boolean",
> +    "description": "Count the number of times the user explicitly the hidden-plugin infobar without choosing allow or continue-blocking.",

"user explicitly the" -> "user explicitly dismisses the"

Comment 3

[[e-mail]]

:bsmedberg I assert you are requesting a type 2 measurement, as it is about interaction with the UI surface of the chrome.  Correct?  If so, r+

Comment 4

[Benjamin Smedberg]

Yes. Although if we're going to start using "type 1/2" we should probably document that at https://wiki.mozilla.org/Firefox/Data_Collection

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c3a2ed2ce954
Prefs and telemetry for hidden-plugin infobars. This patch does not change any defaults, but provides options which we'll test via A/B testing and telemetry to measure success. r=mconley data-r=rweiss

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c3a2ed2ce954

Comment 7

[Abe - QA (:Abe_LV)]

We have tested part the"pref which can suppress infobars entirely" and it is green.
Test cases and runs are here: https://public.etherpad-mozilla.org/p/1368060
Please needinfo me if additional testing is required. Thanks

Comment 8

[Abe - QA (:Abe_LV)]

verified as fixed.