1368109 - No need to sync set gfx.direct2d.disabled to layers.acceleration.disabled

Status: RESOLVED FIXED

(Core :: Graphics, enhancement)

Description

[Milan Sreckovic [:milan] (needinfo for best results)]

We have complications in the UI code that sets gfx.direct2d.disabled preference to the same value as layers.acceleration.disabled.  This is not necessary anymore, and we should simplify that code, especially now that the UI for preferences is changing.

Comment 1

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: Bug 1368109: No need to sync layers.acceleration.disabled and gfx.direct2d.disabled on Windows.

Review commit: https://reviewboard.mozilla.org/r/143336/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/143336/

Comment 2

[Mason Chang [Inactive] [:mchang]]

So we can have D2D with layers.acceleration enabled? Why is this not necessary anymore?

Comment 3

[Milan Sreckovic [:milan] (needinfo for best results)]

Good question.

Just disabling the layers acceleration (using the pref) will stop us from using D2D (which requires D3D11 compositor.) Used to be that D2D preference was "stronger" than the layers acceleration, and would force the accelerated compositor.

So, we're never going to end up with unaccelerated compositor and D2D, because unaccelerated compositor forces non-D2D content.

This patches doesn't change that - just removes the complication in the code where we synchronize the values of two preferences - not necessary anymore.

Comment 4

[Mason Chang [Inactive] [:mchang]]

Comment on attachment 8871835 [details]
Bug 1368109: No need to sync layers.acceleration.disabled and gfx.direct2d.disabled on Windows.

https://reviewboard.mozilla.org/r/143336/#review147074

Thanks for the explanation!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/740d674779eb
No need to sync layers.acceleration.disabled and gfx.direct2d.disabled on Windows. r=mchang

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/740d674779eb