No need to sync set gfx.direct2d.disabled to layers.acceleration.disabled

RESOLVED FIXED in Firefox 55

Status

()

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: milan, Assigned: milan)

Tracking

(Blocks: 1 bug)

unspecified
mozilla55
Unspecified
Windows
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: gfx-noted)

Attachments

(1 attachment)

We have complications in the UI code that sets gfx.direct2d.disabled preference to the same value as layers.acceleration.disabled.  This is not necessary anymore, and we should simplify that code, especially now that the UI for preferences is changing.
Assignee: nobody → milan
Comment hidden (mozreview-request)
Whiteboard: gfx-noted
So we can have D2D with layers.acceleration enabled? Why is this not necessary anymore?
Flags: needinfo?(milan)
Good question.

Just disabling the layers acceleration (using the pref) will stop us from using D2D (which requires D3D11 compositor.) Used to be that D2D preference was "stronger" than the layers acceleration, and would force the accelerated compositor.

So, we're never going to end up with unaccelerated compositor and D2D, because unaccelerated compositor forces non-D2D content.

This patches doesn't change that - just removes the complication in the code where we synchronize the values of two preferences - not necessary anymore.
Flags: needinfo?(milan)
OS: Unspecified → Windows

Comment 4

a year ago
mozreview-review
Comment on attachment 8871835 [details]
Bug 1368109: No need to sync layers.acceleration.disabled and gfx.direct2d.disabled on Windows.

https://reviewboard.mozilla.org/r/143336/#review147074

Thanks for the explanation!
Attachment #8871835 - Flags: review?(mchang) → review+

Comment 5

a year ago
Pushed by msreckovic@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/740d674779eb
No need to sync layers.acceleration.disabled and gfx.direct2d.disabled on Windows. r=mchang

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/740d674779eb
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.