1368139 - Errors are swallowed when a macro called by another macro has an error

Status: RESOLVED WORKSFORME

(developer.mozilla.org Graveyard :: KumaScript, defect)

Description

[Will Bamberg [:wbamberg]]

With KumaScript, if a macro has an error, it displays a red box with useful information about the error.

Also with KumaScript macros can call other macros by doing things like:

  template("MyOtherMacro", [someArg])

This is useful for sharing code. However, if a macro calls another macro, and the other macro has an error, then Kuma does not show the error box: the error is just swallowed, and nothing is displayed.

Comment 1

[Will Bamberg [:wbamberg]]

I think this is fixed by https://bugzilla.mozilla.org/show_bug.cgi?id=1509430 \o/

Comment 2

[John Whitlock [:jwhitlock]]

Good memory wbamberg! I'm not aware of any pages that had this problem, so I'm going with your judgement. If we find one that still has the bug, re-open or create a new bug please.

Comment 3

[John Whitlock [:jwhitlock]]

bug 1522206 may be an example. https://developer.mozilla.org/zh-CN/docs/Mozilla/Add-ons/WebExtensions/API/bookmarks shows this error:

Error rendering macro 'AddonSidebar' at line 1, column 6 of document:
    1 | <div>{{AddonSidebar}}</div>
-------------^
    2 | 
    3 | <p>此<a href="/zh-CN/docs/Mozilla/Add-ons/WebExtensions">WebExtensions</a> {{WebExtAPIRef("bookmarks")}} API允许一个附加组件和浏览器的书签系统交互和操作。您可以用它给页面加书签，获取已有的书签，以及编辑，移除和管理书签。</p>
/app/macros/AddonSidebar.ejs:379
    377|       <details <%=currentPageIsUnder('WebExtensions/API')%>>
    378|         <summary><%=text['WebExtensions/API']%></summary>
 >> 379|         <%-await template("WebExtAPISidebar", [])%>
    380|       </details>
    381|     </li>
    382| 

/app/macros/WebExtAPISidebar.ejs:1
 >> 1| <%
    2| 
    3| var output = "";
    4| var pageModule = page;

text is not defined;