136816 - Wrong comparison directive in bug_form.pl

Status: RESOLVED DUPLICATE of bug 136751

(Bugzilla :: Administration, task, P3)

Description

[Andreas Höfler]

Line 289 in bug_form.pl:
    $bug{'qa_contact'} = $bug{'qa_contact'} > 0 ? 

Shouldn't this be:
    $bug{'qa_contact'} = $bug{'qa_contact'} gt '0' ? 

or something like that? (I'm not very familiar with perl yet)

Currently it seems to cause error-messages in apace:
[Thu Apr 11 08:06:54 2002] show_bug.cgi: Argument "" isn't numeric in numeric gt
(>) at (eval 10) line 9.

Comment 1

[Gervase Markham [:gerv]]

Are you sure it's that line of code producing the error? Perl translates on the
fly between strings representing numbers and the number themselves; the sort of
thing which produces that error is 

if (247 > "foo") {
...

Gerv

Comment 2

[Bradley Baetz (:bbaetz)]

can you print the value of $bug{'qa_contact'} ?

Comment 3

[Andreas Höfler]

Im not 100% sure if it is THAT line, which causes the error, coz im not very
experienced with perl (and templates) but I found the error in my error_log and
looked over every file which has something to do with show_bug.cgi.

And this line seemed highly suspiciously to me.

The qa-contact-feature is turned on in my bz-install, although I have not
entered any users yet as qa-contacts...

Comment 4

[Bradley Baetz (:bbaetz)]

I can't reproduce this, with or without qa contacts enabled. When is your CVS
bugzilla from?

Comment 5

[Andreas Höfler]

updated yesterday morning...

Comment 6

[Bradley Baetz (:bbaetz)]

Can you add to globals.pl, in the Template->new call:

COMPILE_EXT => ".ttc",

as one of the hash values? The rerun the script. The error message will now
refer to a real file - paste the line it mentions, and about 5 lines each side.
Mention the line #, too.

Afterwards, remove that line, and the ..tc file in teh template/default
directory, otherwise it will cause problmes when precompiled tmeplates are
tunred on correctly.

Comment 7

[Bradley Baetz (:bbaetz)]

Dupe of bug 136751, from looking at compiled templates (I think; if you can
reproduce this with that bug fix, please reopen)

*** This bug has been marked as a duplicate of 136751 ***

Comment 8

[Dave Miller [:justdave]]

clearing target milestone on invalid/duplicate/worksforme/wontfix bugs so
they'll show up as untriaged if they get reopened.