Closed Bug 1368177 Opened 2 years ago Closed 2 years ago

quote {LIB,}CLANG_PATH for cargo

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(1 file)

I'm not sure why this hasn't bit people before...
These paths can contain spaces, particularly if they point into
${HOME}/.mozbuild on Windows.  If people are bold enough to use the
Windows packages from llvm.org, the LLVM packages are installed by
default into C:\Program Files\LLVM, so paths from there would contain
spaces as well.
Attachment #8871935 - Flags: review?(giles)
(In reply to Nathan Froyd [:froydnj] from comment #0)
> I'm not sure why this hasn't bit people before...

Because I was manually quoting the space in the path? (such as --with-clang-path="D:/Program\ Files/LLVM/bin/clang.exe")
(In reply to Masatoshi Kimura [:emk] from comment #2)
> (In reply to Nathan Froyd [:froydnj] from comment #0)
> > I'm not sure why this hasn't bit people before...
> 
> Because I was manually quoting the space in the path? (such as
> --with-clang-path="D:/Program\ Files/LLVM/bin/clang.exe")

Indeed.  We could advise people to do that in the instructions from `mach bootstrap`, but I think this solution is more robust.

Although we *do* assume in many places throughout the build system that paths do not have spaces in them, so I'm not sure if making an exception here is a good idea.
Attachment #8871935 - Flags: review?(giles) → review+
llvm being in "Program Files" seems like a good reason to make an exception here.
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7660dd818a35
quote {LIB,}CLANG_PATH for cargo; r=rillian
https://hg.mozilla.org/mozilla-central/rev/7660dd818a35
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.