Closed Bug 1368180 Opened 7 years ago Closed 6 years ago

BB doesn't coalesce jobs created by BBB

Categories

(Release Engineering :: General, enhancement, P3)

Product:
Release Engineering
Component:
General
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: catlee, Unassigned)

References

Details

Not sure if this is by design or accident, but right now it's impossible for Buildbot to coalesce jobs that were created by BBB.

The offending pieces are code are:

BBB[1] where we create the BB database entries, but we don't create the necessary  entries to represent the change objects.

buildbot's SourceStamp.canBeMergedWith()[2] will return False for two sourcestamps that don't have change objects attached.

The fix is to have BBB create the entries in the DB to represent the change objects.


[1] https://github.com/mozilla-releng/buildbot-bridge/blob/5a29c95a1db63bcd418c90c3b638c98e12bfec0b/bbb/servicebase.py#L238

[2] https://hg.mozilla.org/build/buildbot/file/tip/master/buildbot/sourcestamp.py#l67
Summary: BBB doesn't coalesce jobs → BB doesn't coalesce jobs created by BBB
Blocks: 1370907
Component: General Automation → General
With BB dead, I think we can close this, right?
Flags: needinfo?(catlee)
Yup
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(catlee)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.