1368202 - convert uses of "defer" to "new Promise" in client/inspector

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Comment 1

[Patrick Brosset <:pbro>]

DevTools bug triage (filter on CLIMBING SHOES).

Comment 2

[Nicolas Ouellet-Payeur [:nicolaso]]

Matthieu, are you still working on this? If not, could I pick this up? It seems easy enough.

Comment 3

[Matt R [:stylizit] (slow, away until Sep)]

(In reply to Nicolas Ouellet-Payeur from comment #2)
> Matthieu, are you still working on this? If not, could I pick this up? It
> seems easy enough.

Hi Nicolas, sorry for the late reply. I won't be able to contribute until September, so for sure, feel free to go for it!

Comment 4

[Nicolas Ouellet-Payeur [:nicolaso]]

Attachment: Bug 1368202 - convert uses of "defer" to "new Promise" in client/inspector

Review commit: https://reviewboard.mozilla.org/r/164284/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/164284/

Comment 5

[Nicolas Ouellet-Payeur [:nicolaso]]

Here's a first patch. Added you as reviewer, Tom, since Matt is away, and you seem to have reviewed similar patches.

Comment 6

[Tom Tromey :tromey]

Comment on attachment 8893247 [details]
Bug 1368202 - convert uses of "defer" to "new Promise" in client/inspector

https://reviewboard.mozilla.org/r/164284/#review169828

Thank you for the patch.  This looks good.

Can you do a try run?  If you don't have sufficient permission, let me know and I will do it.

::: devtools/client/inspector/computed/computed.js:12
(Diff revision 1)
>  "use strict";
>  
>  const ToolDefinitions = require("devtools/client/definitions").Tools;
>  const CssLogic = require("devtools/shared/inspector/css-logic");
>  const {ELEMENT_STYLE} = require("devtools/shared/specs/styles");
>  const promise = require("promise");

I just wanted to note that with this patch in place, the inspector will use a combination of Promise (DOM promises) and "promise" (Promise.jsm promises).

That seems possibly confusing, but it seems to me that (1) we brought this on ourselves by having multiple promises in the first place, and (2) it is temporary due to bug 1384527.

So, I am inclined to not worry about it here, at least assuming that the result passes try.

Comment 7

[Nicolas Ouellet-Payeur [:nicolaso]]

> Can you do a try run?  If you don't have sufficient permission, let me know
> and I will do it.

No, I don't have the permissions to trigger a try run yet. Can you do it for me?

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24eaf9aca85c
convert uses of "defer" to "new Promise" in client/inspector r=tromey

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/24eaf9aca85c

Comment 10

[Aki Sasaki (not active)]

https://hg.mozilla.org/projects/date/rev/24eaf9aca85c2bf6664ea92d295003f9c0be835b
Bug 1368202 - convert uses of "defer" to "new Promise" in client/inspector r=tromey