Closed
Bug 1368219
Opened 7 years ago
Closed 7 years ago
Intermittent toolkit/components/osfile/tests/xpcshell/test_available_free_space.js | application crashed [@ js::LifoAlloc::freeAll] [@ JSScript::finalize][@ mozilla::DeadlockDetector<mozilla::BlockingResourceBase>::Remove]
Categories
(Toolkit Graveyard :: OS.File, defect)
Toolkit Graveyard
OS.File
Tracking
(firefox-esr45 unaffected, firefox-esr52 unaffected, firefox53 unaffected, firefox54 unaffected, firefox55+ wontfix, firefox56 disabled, firefox57 fixed)
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox-esr45 | --- | unaffected |
firefox-esr52 | --- | unaffected |
firefox53 | --- | unaffected |
firefox54 | --- | unaffected |
firefox55 | + | wontfix |
firefox56 | --- | disabled |
firefox57 | --- | fixed |
People
(Reporter: intermittent-bug-filer, Assigned: mccr8)
References
Details
(Keywords: crash, intermittent-failure, Whiteboard: [stockwell fixed:product])
Crash Data
Attachments
(1 file)
Filed by: philringnalda [at] gmail.com https://treeherder.mozilla.org/logviewer.html#?job_id=102466553&repo=mozilla-inbound https://queue.taskcluster.net/v1/task/AUbUvzG_RWyX7FOlv4ANOw/runs/0/artifacts/public/logs/live_backing.log
Updated•7 years ago
|
Crash Signature: [@ js::LifoAlloc::freeAll] → [@ js::LifoAlloc::freeAll]
[@ JSScript::finalize]
Summary: Intermittent toolkit/components/osfile/tests/xpcshell/test_available_free_space.js | application crashed [@ js::LifoAlloc::freeAll] → Intermittent toolkit/components/osfile/tests/xpcshell/test_available_free_space.js | application crashed [@ js::LifoAlloc::freeAll] [@ JSScript::finalize]
Comment hidden (Intermittent Failures Robot) |
Comment 2•7 years ago
|
||
Bonus fun: this is going to be permaorange on Linux32 when we merge to beta. [Tracking Requested - why for this release]: merge bustage, closed tree, delayed b1.
status-firefox53:
--- → unaffected
status-firefox54:
--- → unaffected
status-firefox55:
--- → affected
status-firefox-esr45:
--- → unaffected
status-firefox-esr52:
--- → unaffected
tracking-firefox55:
--- → ?
Flags: needinfo?(dteller)
Comment 3•7 years ago
|
||
marking as blocker for 55 as this would cause breakage on merge day
Comment hidden (Intermittent Failures Robot) |
Updated•7 years ago
|
Whiteboard: [stockwell needswork]
Comment 5•7 years ago
|
||
This is pretty darn frequent in general right now.
Component: OS.File → JavaScript: GC
Product: Toolkit → Core
Version: unspecified → Trunk
Comment hidden (Intermittent Failures Robot) |
Comment 9•7 years ago
|
||
I can't see anything in the pushlog. Jan do you know of any JIT changes that might have caused this?
Flags: needinfo?(jdemooij)
Comment 10•7 years ago
|
||
Retries confirm that this failure started on a merge, on central, inbound, and autoland: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&filter-searchStr=linux32%20debug%20xpcshell-6&tochange=bce03a8eac301bcd9408b22333b1a67c3eaed057&fromchange=ba1a33add29df1cff5931c5bd82725b8ed4990e5 https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-searchStr=linux32%20debug%20xpcshell-6&tochange=2e0e73ee424fc64c27bf1135e2b95559fb74b27b&fromchange=23c3721b94e901cddd295a378100e9cf98afadc0 https://treeherder.mozilla.org/#/jobs?repo=autoland&filter-searchStr=linux32%20debug%20xpcshell-6&tochange=a8ec7813e32144756ba1ca0455c8794812490e02&fromchange=87b11e483b4fcbd3d7d2e6dc0bf4232b72202967
Comment 11•7 years ago
|
||
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?changeset=bce03a8eac301bcd9408b22333b1a67c3eaed057
Comment 12•7 years ago
|
||
Bug 1311425 could have changed GC timing and exposed something I suppose.
Comment hidden (Intermittent Failures Robot) |
So, if I parse correctly the stack, this crash is not (immediately) caused by one of the uses of finalization in OS.File code, but rather during worker shutdown. Looking at the code (which I haven't touched in ~5 years, so please bear with my poor memory), the most exotic thing that the worker allocates is a js-ctypes `statvfs` struct. Could it be possible that the recent patches have somehow affected js-ctypes struct finalization? There also used to be a hack when sending strings across workers, but I believe that it was removed ages ago.
Flags: needinfo?(dteller)
Comment hidden (Intermittent Failures Robot) |
Comment 16•7 years ago
|
||
(In reply to David Teller [:Yoric] (please use "needinfo") from comment #14) > Could it be possible that the > recent patches have somehow affected js-ctypes struct finalization? Bug 1352430 does affect object finalization but landed a month before this crash started showing up. Still could be related of course.
Comment 17•7 years ago
|
||
FYI, this is currently marked as blocking Monday's merge of 55 to Beta.
Comment 18•7 years ago
|
||
These crashes happen either when finalising JSScripts or when freeing LIFO allocations made by the baseline compiler. They happen during GC on a worker thread while the main thread is waiting for workers to shut down. I haven't been able to reproduce this or work out what's going wrong.
Based on my chat with RyanVM, this is not a blocker for 55.0b1 anymore. Untagging as such.
Comment 20•7 years ago
|
||
this looks to be fixed as of June 6th (2 instances on mozilla-beta on the 13th though). I would prefer to close this bug, but I don't know why this magically disappeared.
Whiteboard: [stockwell needswork] → [stockwell unknown]
Comment hidden (Intermittent Failures Robot) |
Comment 22•7 years ago
|
||
I've no idea what caused this or why it (mostly) disappeared again :(
Flags: needinfo?(jdemooij)
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 25•7 years ago
|
||
At however many different bugs we're up to now, I'm bored with filing new ones for every random signature.
Summary: Intermittent toolkit/components/osfile/tests/xpcshell/test_available_free_space.js | application crashed [@ js::LifoAlloc::freeAll] [@ JSScript::finalize] → Intermittent toolkit/components/osfile/tests/xpcshell/test_available_free_space.js | application crashed [@ js::LifoAlloc::freeAll] [@ JSScript::finalize][@ mozilla::DeadlockDetector<mozilla::BlockingResourceBase>::Remove]
Comment hidden (Intermittent Failures Robot) |
Updated•7 years ago
|
Whiteboard: [stockwell unknown] → [stockwell needswork]
Assignee | ||
Comment 27•7 years ago
|
||
I'll just remove this test and the getAvailableFreeSpace function, as it doesn't seem to be used, and this code is not really maintained.
Assignee: nobody → continuation
Component: JavaScript: GC → OS.File
Flags: needinfo?(jcoppeard)
Product: Core → Toolkit
Assignee | ||
Comment 28•7 years ago
|
||
This appears to be the first test in the directory, so hopefully there's not some broader problem here. I'll do a bunch of retriggers for whatever subtest runs this directory to see if anything else shows up. https://treeherder.mozilla.org/#/jobs?repo=try&revision=6641445ef9925df33c3f4f896e257eb720b4d2d2
Comment hidden (mozreview-request) |
Comment 30•7 years ago
|
||
mozreview-review |
Comment on attachment 8899157 [details] Bug 1368219 - Remove the unused OSFile.getAvailableFreeSpace. https://reviewboard.mozilla.org/r/170436/#review175602 Now that freeform add-ons aren't supported anymore, anything we can trim off from OS.File is a benefit and will simplify bug 1231711 (or any candidate replacement for OS.File).
Attachment #8899157 -
Flags: review?(dteller) → review+
Comment hidden (obsolete) |
Comment hidden (mozreview-request) |
Comment hidden (obsolete) |
Assignee | ||
Comment 34•7 years ago
|
||
Hrmph. Something on the autoland branch must be breaking this, as I rebased to tip m-c. I guess I'll wait for the next merge and try again.
Comment hidden (Intermittent Failures Robot) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 37•7 years ago
|
||
FWIW, it was bug 1379256 that caused merge conflicts.
Comment 38•7 years ago
|
||
Pushed by amccreight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1bb5bcc356b4 Remove the unused OSFile.getAvailableFreeSpace. r=Yoric
Comment 39•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1bb5bcc356b4
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Updated•7 years ago
|
Updated•7 years ago
|
Whiteboard: [stockwell needswork] → [stockwell fixed:product]
Comment 40•7 years ago
|
||
I'm thinking it'd be lower risk to just skip the test on Beta rather than backporting the removal patch. What are your thoughts, mccr8?
status-firefox56:
--- → affected
Flags: needinfo?(continuation)
Assignee | ||
Comment 41•7 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #40) > I'm thinking it'd be lower risk to just skip the test on Beta rather than > backporting the removal patch. What are your thoughts, mccr8? That sounds reasonable to me. In theory, an addon on beta could be calling this method.
Flags: needinfo?(continuation)
Comment 42•7 years ago
|
||
Disabled on Beta. https://hg.mozilla.org/releases/mozilla-beta/rev/377246626a7d
Updated•10 months ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•