Closed Bug 1368281 Opened 3 years ago Closed 3 years ago
Identity popup is cut off
142.27 KB, image/png
48.46 KB, image/png
Bug 1368281 - Consistently use label and description in the tracking protection section of the identity popup.
59 bytes, text/x-review-board-request
What did you do? 1. Visit any website (e.g. bugzilla.mozilla.org). 2. Click on the page information button in the address bar. What happened? Page information box is cut off at the bottom (at the permissions part). What should have happened? Page info box should fully display all contents and show a bit of padding at the bottom.
Happens with the current 2017-05-27 Nightly, the 2017-05-26 one and I think the 2017-05-25 one too.
I don't have the shield on BMO with Nightly. Any website to have a large page information panel?
The shield comes from the tracking protection, which is enabled by default in the private browsing mode. I have it enabled everywhere. You can either open a new private window and visit any website, or enable tracking protection everywhere.
Then you should be able to reproduce the behavior.
I tried with FF55 and resolution at 100/125%, I can't reproduce it. I think it's related to your locale (DE) which displays some text on 2 lines in the identity panel.
Component: Page Info Window → Site Identity and Permission Panels
Thanks for reporting! Can you confirm that this only occurs in Nightly and not in e.g. Beta or Release?
Summary: Page information box is cut off → Identity popup is cut off
Ok it's happening to me, too. I think I can reliably reproduce it when the tracking protection button is shown. Paolo, do you think this regressed with bug 1009116?
Flags: needinfo?(Adrian.Tiefenbrunner) → needinfo?(paolo.mozmail)
Regression window(de): https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=291a11111bdd05c5cd55dd552da4b1285ceba9b2&tochange=0ed0fd886134b6698f593edbf0d362ac9e12fe07 And 54beta11(de) is no problem.
(In reply to Johann Hofmann [:johannh] from comment #8) > Paolo, do you think this regressed with bug 1009116? Yes, and the solution is to turn the <label> elements in the section into <description> elements (and update the styling rules). I can review a patch that does this quickly.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Sounds good, I'll do it then.
Comment on attachment 8872617 [details] Bug 1368281 - Consistently use label and description in the tracking protection section of the identity popup. https://reviewboard.mozilla.org/r/144160/#review147986 Thanks for fixing the permissions area margin as well!
Attachment #8872617 - Flags: review?(paolo.mozmail) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/b71563f27958 Consistently use label and description in the tracking protection section of the identity popup. r=Paolo
Screenshots: https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=fbe0e3f31233cc7846a2168c613452a1d7147cc2&newProject=mozilla-central&newRev=5b2c84104a7f4774fd120ab38d21b6483bcb63c7 The bottom padding is slightly larger when there are permissions, but I'd say it's ok.
I have reproduced this Bug on Nightly 55.0a1 (2017-05-27) on Windows 10, 64 Bit! The bug's fix is now verified on latest Nightly 55.0a1 Build ID 20170601030206 User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0 [bugday-20170531]
Status: RESOLVED → VERIFIED
Let's make sure this works as intended on Mac and Linux as well. Flagging for additional regression testing.
I have managed to reproduce the issue mentioned in comment 0 with Firefox Nightly 55.0a1 (Build Id:20170527030204). I can confirm that this issue is verified fixed on Firefox Nightly 55.0a1 (Build Id:20170612030208) using Windows 10 64 bit, MacOS 10.11.6 and Ubuntu 16.04 64bit. Thanks Saddam!
You need to log in before you can comment on or make changes to this bug.