Closed Bug 1368285 Opened 3 years ago Closed 3 years ago

Make test_nuke_webextension_wrappers.js correctly wait for the window to be destroyed instead of relying on the scheduling of the corresponding event

Categories

(Core :: XPConnect, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → ehsan
Blocks: 1361461
Depends on: 1368286
Comment on attachment 8872105 [details] [diff] [review]
Make test_nuke_webextension_wrappers.js correctly wait for the window to be destroyed instead of relying on the scheduling of the corresponding event

Review of attachment 8872105 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/xpconnect/tests/unit/test_nuke_webextension_wrappers.js
@@ +12,5 @@
> +      Services.obs.removeObserver(observer, "inner-window-destroyed");
> +      setTimeout(callback, 0);
> +    }
> +  };
> +  Services.obs.addObserver(observer, "inner-window-destroyed");

Same comments as the other window destroyed patch.
Attachment #8872105 - Flags: review?(kmaglione+bmo) → review+
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4747ae7509f1
Make test_nuke_webextension_wrappers.js correctly wait for the window to be destroyed instead of relying on the scheduling of the corresponding event; r=kmag
https://hg.mozilla.org/mozilla-central/rev/4747ae7509f1
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.