1368289 - Remove the frameloader global tracking in ExtensionPageContent.jsm

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P1)

Description

[Kris Maglione [:kmag]]

It's way over-complicated, and also way too expensive.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1368289: Don't needlessly load ExtensionContent.jsm in all processes.

Review commit: https://reviewboard.mozilla.org/r/143602/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/143602/

Comment 2

[Kris Maglione [:kmag]]

Attachment: Bug 1368289: Simplify frameloader global metadata tagging.

Review commit: https://reviewboard.mozilla.org/r/143604/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/143604/

Comment 3

[Kris Maglione [:kmag]]

This is pretty critical for perf.

Comment 4

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8872106 [details]
Bug 1368289: Don't needlessly load ExtensionContent.jsm in all processes.

https://reviewboard.mozilla.org/r/143602/#review150960

Comment 5

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8872107 [details]
Bug 1368289: Simplify frameloader global metadata tagging.

https://reviewboard.mozilla.org/r/143604/#review150958

r+ with comment resolved.

::: toolkit/components/extensions/ExtensionPageChild.jsm:330
(Diff revision 1)
> -      this.contentGlobals.get(global).uninit();
> +      global.docShell.isAppTab = true;
> -      this.contentGlobals.delete(global);
>      }
> -  },
>  
> -  observe(subject, topic, data) {
> +    promiseEvent(global, "DOMContentLoaded", true).then(() => {

IIRC inline browsers (e.g. options panel in about:addons) dont get DCL.  Will that be a problem here?

Comment 6

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bd9dcec1adc156e39f590099b030ed8c0966184f
Bug 1368289: Simplify frameloader global metadata tagging. r=mixedpuppy

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bd9dcec1adc1