Closed
Bug 1368289
Opened 7 years ago
Closed 7 years ago
Remove the frameloader global tracking in ExtensionPageContent.jsm
Categories
(WebExtensions :: General, enhancement, P1)
WebExtensions
General
Tracking
(firefox56 fixed)
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: kmag, Assigned: kmag)
References
(Blocks 1 open bug)
Details
(Whiteboard: triaged)
Attachments
(2 files)
It's way over-complicated, and also way too expensive.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Updated•7 years ago
|
Priority: -- → P2
Whiteboard: triaged
Assignee | ||
Comment 3•7 years ago
|
||
This is pretty critical for perf.
Blocks: webext-perf
Priority: P2 → P1
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8872106 [details] Bug 1368289: Don't needlessly load ExtensionContent.jsm in all processes. https://reviewboard.mozilla.org/r/143602/#review150960
Attachment #8872106 -
Flags: review?(mixedpuppy) → review+
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8872107 [details] Bug 1368289: Simplify frameloader global metadata tagging. https://reviewboard.mozilla.org/r/143604/#review150958 r+ with comment resolved. ::: toolkit/components/extensions/ExtensionPageChild.jsm:330 (Diff revision 1) > - this.contentGlobals.get(global).uninit(); > + global.docShell.isAppTab = true; > - this.contentGlobals.delete(global); > } > - }, > > - observe(subject, topic, data) { > + promiseEvent(global, "DOMContentLoaded", true).then(() => { IIRC inline browsers (e.g. options panel in about:addons) dont get DCL. Will that be a problem here?
Attachment #8872107 -
Flags: review?(mixedpuppy) → review+
Assignee | ||
Comment 6•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd9dcec1adc156e39f590099b030ed8c0966184f Bug 1368289: Simplify frameloader global metadata tagging. r=mixedpuppy
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bd9dcec1adc1
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•