Permared in SM(cgc) when Gecko 55 merges to beta on 2017-06-12 from bug 1367088

RESOLVED FIXED in Firefox 55

Status

()

Core
JavaScript Engine: JIT
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: philor, Assigned: anba)

Tracking

55 Branch
mozilla55
Points:
---

Firefox Tracking Flags

(firefox-esr45 unaffected, firefox-esr52 unaffected, firefox53 unaffected, firefox54 unaffected, firefox55blocking fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

a year ago
Things were fine up through https://hg.mozilla.org/mozilla-central/rev/0414ffab16f8, but with https://hg.mozilla.org/mozilla-central/rev/4769df59b9c2 we get permanent failure with " testInAssertion failure: cell->isMarked(GRAY), at /home/worker/workspace/build/src/js/src/jsapi-tests/testGCHeapPostBarriers.cpp:205" in both the Linux64 and Windows SM(cgc) runs in trunk-as-beta simulations.

According to me in bug 1351467, you should be able to reproduce locally by changing /config/milestone.txt from 55a1 to 55, and (on Linux) running python js/src/devtools/automation/autospider.py compacting

[Tracking Requested - why for this release]: merge bustage, closed tree, delayed b1.
marking as blocker for 55.  Andre, would you mind taking a look?
tracking-firefox55: ? → blocking
Flags: needinfo?(andrebargull)
(Assignee)

Comment 3

a year ago
Created attachment 8872527 [details] [diff] [review]
bug1368344.patch

:jonco, is it the right call to disable GC zeal for this test case? At least it seems to fix the assertion.
Attachment #8872527 - Flags: feedback?(jcoppeard)
(Assignee)

Comment 4

a year ago
(In reply to Phil Ringnalda (:philor) from comment #0)
> Things were fine up through
> https://hg.mozilla.org/mozilla-central/rev/0414ffab16f8, but with
> https://hg.mozilla.org/mozilla-central/rev/4769df59b9c2 we get permanent
> failure with " testInAssertion failure: cell->isMarked(GRAY), at
> /home/worker/workspace/build/src/js/src/jsapi-tests/testGCHeapPostBarriers.
> cpp:205" in both the Linux64 and Windows SM(cgc) runs in trunk-as-beta
> simulations.

Bug 1367088 added a new function to the self-hosting global object, which led to changed GC timings, resulting in the observed assertion.
Comment on attachment 8872527 [details] [diff] [review]
bug1368344.patch

Review of attachment 8872527 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, we should disable zeal for this test.  Thanks for fixing.
Attachment #8872527 - Flags: feedback?(jcoppeard) → review+
(Assignee)

Updated

a year ago
Flags: needinfo?(andrebargull)
Keywords: checkin-needed
Assignee: nobody → andrebargull

Comment 6

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dd37a9cce28d
Disable GC zeal in testUnbarrieredEquality. r=jonco
Keywords: checkin-needed

Comment 7

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/dd37a9cce28d
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.