1368344 - Permared in SM(cgc) when Gecko 55 merges to beta on 2017-06-12 from bug 1367088

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Phil Ringnalda (:philor)]

Things were fine up through https://hg.mozilla.org/mozilla-central/rev/0414ffab16f8, but with https://hg.mozilla.org/mozilla-central/rev/4769df59b9c2 we get permanent failure with " testInAssertion failure: cell->isMarked(GRAY), at /home/worker/workspace/build/src/js/src/jsapi-tests/testGCHeapPostBarriers.cpp:205" in both the Linux64 and Windows SM(cgc) runs in trunk-as-beta simulations.

According to me in bug 1351467, you should be able to reproduce locally by changing /config/milestone.txt from 55a1 to 55, and (on Linux) running python js/src/devtools/automation/autospider.py compacting

[Tracking Requested - why for this release]: merge bustage, closed tree, delayed b1.

Comment 1

[Phil Ringnalda (:philor)]

Wups, forgot the log link: https://treeherder.mozilla.org/logviewer.html#?job_id=102634222&repo=try from https://treeherder.mozilla.org/#/jobs?repo=try&revision=76ad0b79ad574d6f2aac28fc123475c73c13b0b8

Comment 2

[Julien Cristau [:jcristau]]

marking as blocker for 55.  Andre, would you mind taking a look?

Comment 3

[André Bargull [:anba]]

Attachment: bug1368344.patch

:jonco, is it the right call to disable GC zeal for this test case? At least it seems to fix the assertion.

Comment 4

[André Bargull [:anba]]

(In reply to Phil Ringnalda (:philor) from comment #0)
> Things were fine up through
> https://hg.mozilla.org/mozilla-central/rev/0414ffab16f8, but with
> https://hg.mozilla.org/mozilla-central/rev/4769df59b9c2 we get permanent
> failure with " testInAssertion failure: cell->isMarked(GRAY), at
> /home/worker/workspace/build/src/js/src/jsapi-tests/testGCHeapPostBarriers.
> cpp:205" in both the Linux64 and Windows SM(cgc) runs in trunk-as-beta
> simulations.

Bug 1367088 added a new function to the self-hosting global object, which led to changed GC timings, resulting in the observed assertion.

Comment 5

[Jon Coppeard (:jonco)]

Comment on attachment 8872527 [details] [diff] [review]
bug1368344.patch

Review of attachment 8872527 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, we should disable zeal for this test.  Thanks for fixing.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dd37a9cce28d
Disable GC zeal in testUnbarrieredEquality. r=jonco

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/dd37a9cce28d