Closed
Bug 1368384
Opened 7 years ago
Closed 7 years ago
"send to device" subview on page action menu should indicate the tab was sent
Categories
(Firefox :: Sync, defect, P1)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: markh, Assigned: eoger)
References
Details
Attachments
(1 file)
STR:
* "send to device" subview, then click on a device to send the tab to.
Expected:
* The UI updates to reflect that some action was taken.
Actual:
* The UI doesn't change at all. The user may assume they mis-clicked, and click multiple times.
While this doesn't actually cause the tab to be sent multiple times, it does seem odd and may give the user the impression that the feature hasn't worked.
ISTM the subview should change to some text saying something like "Nice! The tab is on its way to {device name}". I don't believe there are any error states we need to reflect (ie, displaying "it worked" would be unconditional)
|
Assignee | |
Comment 1•7 years ago
|
||
rfeeley: for now we can just close the page action menu. We can do something fancier later.
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → eoger
Status: NEW → ASSIGNED
Priority: -- → P1
|
Reporter | |
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8873135 [details] Bug 1368384 - Close the page action menu when sending tab. https://reviewboard.mozilla.org/r/144604/#review148678
Attachment #8873135 -
Flags: review?(markh) → review+
Pushed by eoger@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9c69d0681cd6 Close the page action menu when sending tab. r=markh
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9c69d0681cd6
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
|
||
Comment 6•7 years ago
|
||
I have reproduced this Bug on Nightly 55.0a1 (2017-05-28) on Windows 10, 64 Bit! The bug's fix is now verified on latest Nightly 55.0a1 Build ID : 20170607030206 User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0 [bugday-20170607]
You need to log in
before you can comment on or make changes to this bug.
Description
•