Closed
Bug 1368454
Opened 7 years ago
Closed 5 years ago
Optimize js::CreateIterResultObject by using ObjectGroup::newPlainObject instead of manually creating the object and defining its properties
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
DUPLICATE
of bug 1394682
People
(Reporter: till, Assigned: till)
Details
Attachments
(1 file)
1.69 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8872310 -
Flags: review?(jdemooij)
Comment 1•7 years ago
|
||
Comment on attachment 8872310 [details] [diff] [review] Optimize js::CreateIterResultObject Review of attachment 8872310 [details] [diff] [review]: ----------------------------------------------------------------- Sorry for the delay.
Attachment #8872310 -
Flags: review?(jdemooij) → review+
Pushed by tschneidereit@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/75d0af6c7c49 Optimize js::CreateIterResultObject by using ObjectGroup::newPlainObject instead of manually creating the object and defining its properties. r=jandem
Comment 3•7 years ago
|
||
Backed out for failing named-yield-spread-obj.js after asserting !type.isSingleton() at ObjectGroup.cpp:792 (at least on the arms): https://hg.mozilla.org/integration/mozilla-inbound/rev/53accdb19e4f336d10a3a93a377b25f89f343826 Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=75d0af6c7c49e3988d2d24efd602d032d6c63de1&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=117522368&repo=mozilla-inbound [task 2017-07-25T14:18:58.193571Z] ## test262/language/expressions/async-generator/named-yield-spread-obj.js: rc = -11, run time = 0.176967 [task 2017-07-25T14:18:58.193680Z] Assertion failure: !type.isSingleton(), at /home/worker/workspace/build/src/js/src/vm/ObjectGroup.cpp:792 [task 2017-07-25T14:18:58.193779Z] TEST-UNEXPECTED-FAIL | test262/language/expressions/async-generator/named-yield-spread-obj.js | (args: "")
Flags: needinfo?(till)
Comment 4•5 years ago
|
||
Fixed in bug 1394682
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
Assignee | ||
Updated•3 years ago
|
Flags: needinfo?(till)
You need to log in
before you can comment on or make changes to this bug.
Description
•