Closed Bug 1368502 Opened 2 years ago Closed 2 years ago

Remove unused import in about:telemetry

Categories

(Toolkit :: Telemetry, enhancement, P3, trivial)

enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: flyingrub, Assigned: flyingrub, Mentored)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Assignee: nobody → flyinggrub
Hrm. If we do this then TelemetrySession isn't hoisted into the console automatically. I think this might be on purpose to allow for this sort of developer use case.

Alessio, Georg, what do you think?
Flags: needinfo?(gfritzsche)
Flags: needinfo?(alessio.placitelli)
Comment on attachment 8872378 [details]
Bug 1368502 - Remove unused import in about:telemetry

https://reviewboard.mozilla.org/r/143882/#review147616
Attachment #8872378 - Flags: review?(chutten)
(In reply to Chris H-C :chutten from comment #2)
> Hrm. If we do this then TelemetrySession isn't hoisted into the console
> automatically. I think this might be on purpose to allow for this sort of
> developer use case.
> 
> Alessio, Georg, what do you think?

I think this is not intentional, but rather a consequence of us forgetting to remove that dependency :-)

This comes off bug 1122480. Before that, we were using |TelemetrySession.getPayload(reason);| directly to get the current data. In that bug we introduced |TelemetryController.getCurrentPingData()|, which calls |TelemetrySession.getPayload()|. I guess we simply forgot to remove the inclusion of TelemetrySession.jsm back then :-P
Flags: needinfo?(alessio.placitelli)
As Alessio said, this is not intentional and can be removed.
Flags: needinfo?(gfritzsche)
Priority: -- → P3
Keywords: checkin-needed
I think this needs a positive review first.
Keywords: checkin-needed
Ok !

Sorry, I totally forgot that :/
Comment on attachment 8872378 [details]
Bug 1368502 - Remove unused import in about:telemetry

https://reviewboard.mozilla.org/r/143882/#review147900
Attachment #8872378 - Flags: review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/703fc5a4a92c
Remove unused import in about:telemetry r=chutten
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/703fc5a4a92c
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.