Closed
Bug 1368502
Opened 7 years ago
Closed 7 years ago
Remove unused import in about:telemetry
Categories
(Toolkit :: Telemetry, enhancement, P3)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: flyingrub, Assigned: flyingrub, Mentored)
References
Details
Attachments
(1 file)
TelemetrySession is imported but unused. https://dxr.mozilla.org/mozilla-central/search?q=file%3AaboutTelemetry.js+TelemetrySession&redirect=false
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
Hrm. If we do this then TelemetrySession isn't hoisted into the console automatically. I think this might be on purpose to allow for this sort of developer use case. Alessio, Georg, what do you think?
Flags: needinfo?(gfritzsche)
Flags: needinfo?(alessio.placitelli)
|
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8872378 [details] Bug 1368502 - Remove unused import in about:telemetry https://reviewboard.mozilla.org/r/143882/#review147616
Attachment #8872378 -
Flags: review?(chutten)
|
||
Comment 4•7 years ago
|
||
(In reply to Chris H-C :chutten from comment #2) > Hrm. If we do this then TelemetrySession isn't hoisted into the console > automatically. I think this might be on purpose to allow for this sort of > developer use case. > > Alessio, Georg, what do you think? I think this is not intentional, but rather a consequence of us forgetting to remove that dependency :-) This comes off bug 1122480. Before that, we were using |TelemetrySession.getPayload(reason);| directly to get the current data. In that bug we introduced |TelemetryController.getCurrentPingData()|, which calls |TelemetrySession.getPayload()|. I guess we simply forgot to remove the inclusion of TelemetrySession.jsm back then :-P
Flags: needinfo?(alessio.placitelli)
|
||
Comment 5•7 years ago
|
||
As Alessio said, this is not intentional and can be removed.
Flags: needinfo?(gfritzsche)
|
|
||
Updated•7 years ago
|
Priority: -- → P3
Keywords: checkin-needed
|
|
||
Comment 8•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8872378 [details] Bug 1368502 - Remove unused import in about:telemetry https://reviewboard.mozilla.org/r/143882/#review147900
Attachment #8872378 -
Flags: review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/703fc5a4a92c Remove unused import in about:telemetry r=chutten
Keywords: checkin-needed
|
||
Comment 10•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/703fc5a4a92c
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•