|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
59 bytes, text/x-review-board-request
|Details | Review|
I am noticing that the grid lines aren't lining up correctly. See https://gridbyexample.com/patterns/media-object/. I did a simple comparison with Firefox release.
Can you look into this and see what is causing this?
Not sure why the older implementation of the grid didn't suffer the issue; however the reason why the highlight is offset by some pixel here is due the border's element. I wrote a patch that add those values in the same way we have done for the padding, that solve the issue.
Assignee: nobody → zer0
Comment on attachment 8874908 [details] Bug 1368535 - translate the matrix also by element's borders; https://reviewboard.mozilla.org/r/146282/#review150354
Attachment #8874908 - Flags: review?(gl) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/94fbb0e81d89 translate the matrix also by element's borders; r=gl
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/8191dc9bb34f translate the matrix also by element's borders; r=gl
You need to log in before you can comment on or make changes to this bug.