Grid Inspector highlight is offset by some pixels

RESOLVED FIXED in Firefox 55

Status

DevTools
Inspector
P1
normal
RESOLVED FIXED
a year ago
12 days ago

People

(Reporter: gl, Assigned: zer0)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 55
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

a year ago
I am noticing that the grid lines aren't lining up correctly. See https://gridbyexample.com/patterns/media-object/. I did a simple comparison with Firefox release.
(Reporter)

Comment 1

a year ago
Can you look into this and see what is causing this?
Flags: needinfo?(zer0)
Comment hidden (mozreview-request)
(Assignee)

Comment 3

a year ago
Not sure why the older implementation of the grid didn't suffer the issue; however the reason why the highlight is offset by some pixel here is due the border's element. I wrote a patch that add those values in the same way we have done for the padding, that solve the issue.
Assignee: nobody → zer0
Flags: needinfo?(zer0)
(Reporter)

Comment 4

a year ago
mozreview-review
Comment on attachment 8874908 [details]
Bug 1368535 - translate the matrix also by element's borders;

https://reviewboard.mozilla.org/r/146282/#review150354
Attachment #8874908 - Flags: review?(gl) → review+

Comment 5

a year ago
Pushed by mferretti@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/94fbb0e81d89
translate the matrix also by element's borders; r=gl
https://hg.mozilla.org/mozilla-central/rev/94fbb0e81d89
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55

Comment 7

a year ago
Pushed by mferretti@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8191dc9bb34f
translate the matrix also by element's borders; r=gl

Updated

12 days ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.