136857 - Enable Pipelining doesn't remain disabled when HTTP 1.0 selected

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, defect)

Description

[David Barnes]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.9+)
Gecko/20020409
BuildID:    2002040903

If I go to Edit->Preferences->Advanced->HTTP Networking and choose HTTP 1.0,
then the "Enable Pipelining" option becomes disabled. This, from my sketchy
understanding, is correct. However, if I shut down Mozilla, restart, and again
go to Edit->Preferences->Advanced->HTTP Networking, then HTTP 1.0 is still
activated, but the "Enable Pipelining" option is enabled.

Reproducible: Always
Steps to Reproduce:
1. Edit->Preferences->Advanced->HTTP Networking
2. Choose HTTP 1.0
3. Notice that "Enable Pipelining" becomes disabled.
4. Close Mozilla
5. Restart Mozilla
6. Edit->Preferences->Advanced->HTTP Networking
7. See that "Enable Pipelining" is enabled and can be chosen.

Expected Results:  I think "Enable Pipelining" should remain disabled, because
it was introduced with HTTP 1.1. At the least, it shouldn't be disabled and then
reenabled after restarting Mozilla.

Comment 1

[Gilles Durys]

Confirming on linux cvs 2002041022

Comment 2

[Gilles Durys]

Attachment: One-line patch

Comment 3

[Kathleen :Brade]

doh! we should probably try to get this fix in the branch?

Comment 4

[Kathleen :Brade]

Comment on attachment 78713 [details] [diff] [review]
One-line patch

r=brade

Comment 5

[Darin Fisher]

Comment on attachment 78713 [details] [diff] [review]
One-line patch

rs=darin

brade: now it all makes sense! ;-)

Comment 6

[Kathleen :Brade]

David Barnes--do you have checkin privileges?  If not, I can check this fix in
for you.

Comment 7

[David Barnes]

I don't have checkin privileges - could you do it? Thanks - that was a fast fix!

Comment 8

[Darin Fisher]

i'll land this on the trunk today.

Comment 9

[Darin Fisher]

fixed-on-trunk

waiting for approval to land this on the 1.0 branch

reassigning to brade

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 78713 [details] [diff] [review]
One-line patch

a=asa (on behalf of drivers) for checkin to the 1.0 branch

Comment 11

[Darin Fisher]

fixed-on-branch

Comment 12

[scottputterman]

Removing adt1.0.0.  It's already been checked in.

Comment 13

[Asa Dotzler [:asa]]

adding fixed1.0.0 keyword (branch resolution). This bug has comments saying it
was fixed on the 1.0 branch and a bonsai checkin comment that agrees. To verify
the bug has been fixed on the 1.0 branch please replace the fixed1.0.0 keyword
with verified1.0.0.

Comment 14

[sairuh (rarely reading bugmail)]

vrfy'd fixed using 2002.07.02.0x-1.0 branch comm bits on linux rh7.2, win2k and
mac 10.1.5.