TabManager.removeDelegate does not actually remove a delegate

RESOLVED FIXED

Status

()

Firefox for iOS
Browser
P1
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: farhan, Assigned: farhan)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [MobileCore])

Attachments

(1 attachment)

55 bytes, text/x-github-pull-request
sleroux
: review+
Details | Review | Splinter Review
(Assignee)

Description

a year ago
TabManager.removeDelegate removes a WeakTabManagerDelegate by comparing by reference. But if the reference has been deinited then the comparison fails and the WeakTabManagerDelegate is never removed.
(Assignee)

Comment 1

a year ago
Created attachment 8872478 [details] [review]
Pull Request
Attachment #8872478 - Flags: review?(sleroux)
Attachment #8872478 - Flags: review?(sleroux) → review+
(Assignee)

Comment 2

a year ago
master https://github.com/mozilla-mobile/firefox-ios/commit/349d26207730f902a6100113597746521e4dcee7
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Whiteboard: [MobileCore] → [MobileCore][needsuplift]
Whiteboard: [MobileCore][needsuplift] → [MobileCore]
Uplifted to v8.x
You need to log in before you can comment on or make changes to this bug.