Favicons for a site fail to load when a single icon from the site fails

RESOLVED FIXED

Status

()

P1
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: farhan, Assigned: farhan)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mobileAS])

Attachments

(1 attachment)

55 bytes, text/x-github-pull-request
sleroux
: review+
Details | Review | Splinter Review
(Assignee)

Description

a year ago
When going to http://earnesticecream.com you'll notice that no favicons are loaded for this url. But looking at the metadata for this page there are 8 favicons available. 


The first one of the 8 results in a 404 and because of that the rest of them never actually load. 

Even if one of the favicons is bad we should be able to use one of the other favicons to show a valid icon. 

PS: If you are in Vancouver sometime. Be sure to try some Earnest!
(Assignee)

Comment 1

a year ago
Created attachment 8872492 [details] [review]
Pull Request
Attachment #8872492 - Flags: review?(sleroux)
Attachment #8872492 - Flags: review?(sleroux) → review+
(Assignee)

Comment 2

a year ago
master https://github.com/mozilla-mobile/firefox-ios/commit/e6864047f10fe50fd2e5bc0f96955cefa161c043
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Whiteboard: [mobileAS] → [mobileAS][needsuplift]
Whiteboard: [mobileAS][needsuplift] → [mobileAS]
Uplifted to v8.x
You need to log in before you can comment on or make changes to this bug.