Intermittent tests\jit-test\jit-test\tests\basic\bug1355573.js | uncaught exception: out of memory (code 3, args "--ion-eager --ion-offthread-compile=off")

RESOLVED FIXED in Firefox 55

Status

()

defect
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: intermittent-bug-filer, Assigned: jandem)

Tracking

({intermittent-failure})

unspecified
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [stockwell fixed])

Attachments

(2 attachments)

Flags: needinfo?(nicolas.b.pierron)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
This failure is very frequent on Windows 7 opt and pgo.

Failures began with bug 1355573:

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-searchStr=windows%20jit&tochange=fe64a3b770fd421ee62896bce58369275555281b&fromchange=4a50cfa3de8009f8e6900ce44a53afa45e28428e
Blocks: 1355573
Flags: needinfo?(jdemooij)
Whiteboard: [stockwell needswork]
Assignee

Comment 5

2 years ago
Posted patch PatchSplinter Review
I added this test a few days ago. It allocates some huge strings and apparently that can make us OOM on 32-bit Windows. I think we can just add allow-oom to the test.
Assignee: nobody → jdemooij
Status: NEW → ASSIGNED
Flags: needinfo?(jdemooij)
Attachment #8873394 - Flags: review?(jcoppeard)
Attachment #8873394 - Flags: review?(jcoppeard) → review+
Comment hidden (Intermittent Failures Robot)

Comment 7

2 years ago
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0b3be4de7ac3
Add allow-oom attribute to bug1355573.js jit-test. r=jonco
Assignee

Comment 8

2 years ago
Hm this doesn't work because the test harness first checks the expected error and so it never gets to the "allow oom" part...
Assignee

Comment 9

2 years ago
Posted patch Another patchSplinter Review
Another patch to avoid using both "error" and "allow-oom". It's tempting to just fix the harness but I don't have the time for it now.
Attachment #8873755 - Flags: review?(jcoppeard)
Attachment #8873755 - Flags: review?(jcoppeard) → review+
Flags: needinfo?(nicolas.b.pierron)

Comment 10

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0b3be4de7ac3
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Assignee

Updated

2 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 11

2 years ago
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0678eef8a8bd
part 2 - Rewrite bug1355573.js jit-test to work around the harness not supporting error + allow-oom. r=jonco

Comment 12

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0678eef8a8bd
Status: REOPENED → RESOLVED
Last Resolved: 2 years ago2 years ago
Resolution: --- → FIXED
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Whiteboard: [stockwell needswork] → [stockwell fixed]
Comment hidden (Intermittent Failures Robot)
You need to log in before you can comment on or make changes to this bug.