Add telemetry to track number of deprecated configurations passed to navigator.requestMediaKeySystemAccess

RESOLVED FIXED in Firefox 55

Status

()

Core
Audio/Video: Playback
P3
normal
RESOLVED FIXED
a year ago
4 months ago

People

(Reporter: cpearce, Assigned: cpearce)

Tracking

(Blocks: 1 bug)

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
In bug 1355252 I'm trying to remove support for some deprecated EME APIs. This change would make our implementation stricter, and so we'd reject some requests to access EME that today would be granted. So I'd like telemetry to track how often we'd reject requests that would otherwise succeed if we make the changes in bug 1355252.
Comment hidden (mozreview-request)

Comment 2

a year ago
mozreview-review
Comment on attachment 8872508 [details]
Bug 1368596 - Add telemetry to track how often deprecated configs are passed to navigator.requestMediaKeySystemAccess().

https://reviewboard.mozilla.org/r/144052/#review147730

r+, assuming the answer is "no" below:

::: dom/media/eme/MediaKeySystemAccessManager.cpp:206
(Diff revision 1)
> +    if (warnings.Get("MediaEMENoCapabilitiesDeprecatedWarning")) {
> +      Telemetry::Accumulate(
> +        Telemetry::HistogramID::MEDIA_EME_REQUEST_DEPRECATED_WARNINGS, 1);
> +      EME_LOG("MEDIA_EME_REQUEST_DEPRECATED_WARNINGS "
> +              "MediaEMENoCapabilitiesDeprecatedWarning");
> +    } else if (warnings.Get("MediaEMENoCodecsDeprecatedWarning")) {

`else if` -- can't have both at the same time?
Attachment #8872508 - Flags: review?(gsquelart) → review+
(Assignee)

Comment 3

a year ago
mozreview-review-reply
Comment on attachment 8872508 [details]
Bug 1368596 - Add telemetry to track how often deprecated configs are passed to navigator.requestMediaKeySystemAccess().

https://reviewboard.mozilla.org/r/144052/#review147730

> `else if` -- can't have both at the same time?

We can't have both at the same time. The "codecs" check happens on a MediaKeySystemCapability's contentType attribute, but if there's no MediaKeySystemCapability (which is what the first warning checks) then there's no contentType to check.

Comment 5

a year ago
mozreview-review
Comment on attachment 8872508 [details]
Bug 1368596 - Add telemetry to track how often deprecated configs are passed to navigator.requestMediaKeySystemAccess().

https://reviewboard.mozilla.org/r/144052/#review147914

datareview+
Attachment #8872508 - Flags: review?(francois) → review+
(Assignee)

Comment 7

a year ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/33c7495a708fc89bc8e730daab1b13b4b93b605e
Bug 1368596 - Add telemetry to track how often deprecated configs are passed to navigator.requestMediaKeySystemAccess(). r=gerald,r=francois

Comment 8

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/33c7495a708f
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
See Also: → bug 1430519
You need to log in before you can comment on or make changes to this bug.