Closed Bug 1368605 Opened 3 years ago Closed 3 years ago

Add various tests for JSON Viewer (1364953, 1367881, 1362504, 1366239)

Categories

(DevTools :: JSON Viewer, enhancement)

enhancement
Not set

Tracking

(firefox55 fixed)

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: Oriol, Assigned: Oriol)

References

Details

Attachments

(1 file, 3 obsolete files)

Attached patch json-tests.patch (obsolete) — Splinter Review
./mach eslint now throws an error so please check it for me.
Attachment #8872512 - Flags: review?(odvarko)
Attached patch json-tests.patch (obsolete) — Splinter Review
I updated to an older revision and now mach eslint works. Fixing the issues.
Attachment #8872512 - Attachment is obsolete: true
Attachment #8872512 - Flags: review?(odvarko)
Attachment #8872633 - Flags: review?(odvarko)
Attached patch json-tests.patch (obsolete) — Splinter Review
I forgot to declare a variable in browser_jsonview_save_json.js, I was overwriting a global one instead. And adding another save test while I'm at it.
Attachment #8872633 - Attachment is obsolete: true
Attachment #8872633 - Flags: review?(odvarko)
Attachment #8872683 - Flags: review?(odvarko)
Comment on attachment 8872683 [details] [diff] [review]
json-tests.patch

Review of attachment 8872683 [details] [diff] [review]:
-----------------------------------------------------------------

Good piece of job here!

R+

Thanks,
Honza

::: devtools/client/jsonview/test/head.js
@@ +26,5 @@
>   * Add a new test tab in the browser and load the given url.
>   * @param {String} url The url to be loaded in the new tab
>   * @return a promise that resolves to the tab object when the url is loaded
>   */
> +function addJsonViewTab(url, timeout = -1) {

Please update the comment to cover also the new argument.
Attachment #8872683 - Flags: review?(odvarko) → review+
Attached patch json-tests.patchSplinter Review
Updating the comment to cover the new argument.
Attachment #8872683 - Attachment is obsolete: true
Attachment #8872988 - Flags: review?(odvarko)
Comment on attachment 8872988 [details] [diff] [review]
json-tests.patch

Review of attachment 8872988 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!


Honza
Attachment #8872988 - Flags: review?(odvarko) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/337c45b2912a
Add various tests for the JSON Viewer. r=Honza
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/337c45b2912a
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.