1368605 - Add various tests for JSON Viewer (1364953, 1367881, 1362504, 1366239)

Status: RESOLVED FIXED

(DevTools :: JSON Viewer, enhancement)

Description

[Oriol Brufau [:Oriol]]

Attachment: json-tests.patch

./mach eslint now throws an error so please check it for me.

Comment 1

[Oriol Brufau [:Oriol]]

Attachment: json-tests.patch

I updated to an older revision and now mach eslint works. Fixing the issues.

Comment 2

[Oriol Brufau [:Oriol]]

Attachment: json-tests.patch

I forgot to declare a variable in browser_jsonview_save_json.js, I was overwriting a global one instead. And adding another save test while I'm at it.

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8872683 [details] [diff] [review]
json-tests.patch

Review of attachment 8872683 [details] [diff] [review]:
-----------------------------------------------------------------

Good piece of job here!

R+

Thanks,
Honza

::: devtools/client/jsonview/test/head.js
@@ +26,5 @@
>   * Add a new test tab in the browser and load the given url.
>   * @param {String} url The url to be loaded in the new tab
>   * @return a promise that resolves to the tab object when the url is loaded
>   */
> +function addJsonViewTab(url, timeout = -1) {

Please update the comment to cover also the new argument.

Comment 4

[Oriol Brufau [:Oriol]]

Attachment: json-tests.patch

Updating the comment to cover the new argument.

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8872988 [details] [diff] [review]
json-tests.patch

Review of attachment 8872988 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!


Honza

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/337c45b2912a
Add various tests for the JSON Viewer. r=Honza

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/337c45b2912a