Add various tests for JSON Viewer (1364953, 1367881, 1362504, 1366239)

RESOLVED FIXED in Firefox 55

Status

RESOLVED FIXED
a year ago
4 months ago

People

(Reporter: Oriol, Assigned: Oriol)

Tracking

unspecified
Firefox 55
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

a year ago
Created attachment 8872512 [details] [diff] [review]
json-tests.patch

./mach eslint now throws an error so please check it for me.
Attachment #8872512 - Flags: review?(odvarko)
(Assignee)

Comment 1

a year ago
Created attachment 8872633 [details] [diff] [review]
json-tests.patch

I updated to an older revision and now mach eslint works. Fixing the issues.
Attachment #8872512 - Attachment is obsolete: true
Attachment #8872512 - Flags: review?(odvarko)
Attachment #8872633 - Flags: review?(odvarko)
(Assignee)

Comment 2

a year ago
Created attachment 8872683 [details] [diff] [review]
json-tests.patch

I forgot to declare a variable in browser_jsonview_save_json.js, I was overwriting a global one instead. And adding another save test while I'm at it.
Attachment #8872633 - Attachment is obsolete: true
Attachment #8872633 - Flags: review?(odvarko)
Attachment #8872683 - Flags: review?(odvarko)
Comment on attachment 8872683 [details] [diff] [review]
json-tests.patch

Review of attachment 8872683 [details] [diff] [review]:
-----------------------------------------------------------------

Good piece of job here!

R+

Thanks,
Honza

::: devtools/client/jsonview/test/head.js
@@ +26,5 @@
>   * Add a new test tab in the browser and load the given url.
>   * @param {String} url The url to be loaded in the new tab
>   * @return a promise that resolves to the tab object when the url is loaded
>   */
> +function addJsonViewTab(url, timeout = -1) {

Please update the comment to cover also the new argument.
Attachment #8872683 - Flags: review?(odvarko) → review+
(Assignee)

Comment 4

a year ago
Created attachment 8872988 [details] [diff] [review]
json-tests.patch

Updating the comment to cover the new argument.
Attachment #8872683 - Attachment is obsolete: true
Attachment #8872988 - Flags: review?(odvarko)
Comment on attachment 8872988 [details] [diff] [review]
json-tests.patch

Review of attachment 8872988 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!


Honza
Attachment #8872988 - Flags: review?(odvarko) → review+
(Assignee)

Updated

a year ago
Keywords: checkin-needed

Comment 6

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/337c45b2912a
Add various tests for the JSON Viewer. r=Honza
Keywords: checkin-needed

Comment 7

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/337c45b2912a
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55

Updated

4 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.