Closed Bug 1368655 Opened 2 years ago Closed 2 years ago
Selecting No when boostrap asks to build stylo downloads clang
Nathan, do we care that mach bootstrap is downloading clang even when the user selects No? Since Stylo will soon part of the default build configuration, developers will need to download clang eventually. Maybe we should just remove the "Would you like to download packages for working on Stylo?" prompt now instead of fixing the download.
Priority: -- → P3
BTW, are we downloading clang even when it's installed locally?
Running bootstrap twice keeps downloading clang, if that is what you mean. Even on macOS with Apple clang installed by default.
(In reply to Chris Peterson [:cpeterson] from comment #1) > Nathan, do we care that mach bootstrap is downloading clang even when the > user selects No? I think we care until Stylo is made mandatory. Perhaps we want to indicate that the user should add --disable-stylo if they don't download Stylo packages, too.
Might as well fix this.
Attachment #8873540 - Flags: review?(giles)
Comment on attachment 8873540 [details] [diff] [review] only download Stylo packages if the user wanted Stylo Review of attachment 8873540 [details] [diff] [review]: ----------------------------------------------------------------- I think there's also some confusion in that it says it's downloading when it's really checking the cache.
Attachment #8873540 - Flags: review?(giles) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/a9f2f087d824 only download Stylo packages if the user wanted Stylo; r=rillian
You need to log in before you can comment on or make changes to this bug.