1368684 - Stop doing separate webrender-enabled builds

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

Back in bug 1335748 and bug 1336479 (among others) we added QR builds to automation. These builds had webrender built in and turned on, and were useful for testing webrender functionality.

Since then, we have made webrender built-in to regular desktop builds as well, and the feature can be enabled at runtime via pref or environment variable. As such, we no longer need the dedicated builds any more, and we should stop producing them.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1368684 - Stop building webrender-enabled builds in automation.

As of bug 1342503 being fixed, all of our desktop firefox builds have
webrender compiled in by default. Webrender can therefore be enabled at
runtime either by a pref or environment variable on any desktop firefox
build. The old builds that we originally used to stand up webrender are
no longer needed, as the *only* difference between them and the regular
builds are that they build with the pref turned on instead of turned
off. This doesn't warrant keeping around these extra builds, and this
patch removes them along with all the associated goop that was needed to
configure them.

Review commit: https://reviewboard.mozilla.org/r/144164/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/144164/

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8872626 [details]
Bug 1368684 - Stop building webrender-enabled builds in automation.

https://reviewboard.mozilla.org/r/144164/#review147958

I can only really speak for the taskcluster/ files, so if you're not confident you might want to seek other reviewers for `testing/**` and `browser/**`

At any rate, this is great, but there's more `-qr` stuff in `taskcluster/ci/tests/{test-platforms,test-sets,tests}.yml` that should be removed too, either in a revision of this patch or in a followup.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

(In reply to Dustin J. Mitchell [:dustin] from comment #2)
> I can only really speak for the taskcluster/ files, so if you're not
> confident you might want to seek other reviewers for `testing/**` and
> `browser/**`

I'm fairly confident this removal is fine - I added all of it just a few months ago.

> At any rate, this is great, but there's more `-qr` stuff in
> `taskcluster/ci/tests/{test-platforms,test-sets,tests}.yml` that should be
> removed too, either in a revision of this patch or in a followup.

That stuff is still being used - we run linux64-qr tests as tier-1 on inbound/autoland/central/graphics. We just don't need these extra build jobs, because we don't use them for anything.

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Ah, I missed that test platform linux64-qr/opt runs on build platform linux64/opt, not linux64-qr/opt.  Carry on!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/804506642522
Stop building webrender-enabled builds in automation. r=dustin

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/804506642522