Closed Bug 1368684 Opened 2 years ago Closed 2 years ago

Stop doing separate webrender-enabled builds

Categories

(Core :: Graphics: WebRender, enhancement, P3)

55 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: kats, Assigned: kats)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

Back in bug 1335748 and bug 1336479 (among others) we added QR builds to automation. These builds had webrender built in and turned on, and were useful for testing webrender functionality.

Since then, we have made webrender built-in to regular desktop builds as well, and the feature can be enabled at runtime via pref or environment variable. As such, we no longer need the dedicated builds any more, and we should stop producing them.
Comment on attachment 8872626 [details]
Bug 1368684 - Stop building webrender-enabled builds in automation.

https://reviewboard.mozilla.org/r/144164/#review147958

I can only really speak for the taskcluster/ files, so if you're not confident you might want to seek other reviewers for `testing/**` and `browser/**`

At any rate, this is great, but there's more `-qr` stuff in `taskcluster/ci/tests/{test-platforms,test-sets,tests}.yml` that should be removed too, either in a revision of this patch or in a followup.
Attachment #8872626 - Flags: review?(dustin) → review+
(In reply to Dustin J. Mitchell [:dustin] from comment #2)
> I can only really speak for the taskcluster/ files, so if you're not
> confident you might want to seek other reviewers for `testing/**` and
> `browser/**`

I'm fairly confident this removal is fine - I added all of it just a few months ago.

> At any rate, this is great, but there's more `-qr` stuff in
> `taskcluster/ci/tests/{test-platforms,test-sets,tests}.yml` that should be
> removed too, either in a revision of this patch or in a followup.

That stuff is still being used - we run linux64-qr tests as tier-1 on inbound/autoland/central/graphics. We just don't need these extra build jobs, because we don't use them for anything.
Ah, I missed that test platform linux64-qr/opt runs on build platform linux64/opt, not linux64-qr/opt.  Carry on!
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/804506642522
Stop building webrender-enabled builds in automation. r=dustin
https://hg.mozilla.org/mozilla-central/rev/804506642522
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.