Closed Bug 1368718 Opened 3 years ago Closed 3 years ago

Rename macosx generic-worker type to gecko-t-osx-1010

Categories

(Firefox Build System :: Task Configuration, task, P1)

All
macOS
task

Tracking

(Not tracked)

RESOLVED FIXED
mozilla55

People

(Reporter: wcosta, Assigned: wcosta)

References

Details

Attachments

(2 files)

No description provided.
Blocks: 1367448
with provisionerId `releng-hardware` plz
Rename it to releng-hardware/gecko-t-osx-1010.
Attachment #8872746 - Flags: review?(dustin)
Comment on attachment 8872744 [details]
Bug 1368718: rename worker type.

https://reviewboard.mozilla.org/r/144268/#review148044
Attachment #8872744 - Flags: review?(dustin) → review+
Attachment #8872746 - Flags: review?(dustin) → review+
I think that machines repuppetized are having issues with scopes:
  "message": "You do not have sufficient scopes. This request requires you\nto have one of the following sets of scopes:\n[\n  [\n    \"queue:poll-task-urls\",\n    \"assume:worker-type:releng-hardware/gecko-t-osx-\"\n  ],\n  [\n    \"queue:poll-task-urls:releng-hardware/gecko-t-osx-\"\n  ]\n]\n\nYou only have the scopes:\n[\n  \"assume:worker-id:*\",\n  \"assume:worker-type:scl3-puppet/os-x-*\",\n  \"auth:sentry:generic-worker\",\n  \"auth:statsum:generic-worker\",\n  \"queue:claim-task\",\n  \"queue:claim-work:scl3-puppet/*\",\n  \"queue:create-artifact:*\",\n  \"queue:pending-tasks:scl3-puppet/*\",\n  \"queue:poll-task-urls\",\n  \"queue:resolve-task\",\n  \"queue:worker-id:*\"\n]\n\nIn other words you are missing scopes from one of the options:\n * Option 0:\n    - \"assume:worker-type:releng-hardware/gecko-t-osx-\"\n * Option 1:\n    - \"queue:poll-task-urls:releng-hardware/gecko-t-osx-\"\n----\nmethod:     pollTaskUrls\nerrorCode:  InsufficientScopes\nstatusCode: 403\ntime:       2017-06-01T03:33:42.468Z",

note the worker type it's trying to use "gecko-t-osx-" rather than something like "gecko-t-osx-1010"

Also, once that's fixed, the client ID being used for these machines needs the scopes for that new provisioner ID and worker type.

Side note: I see that it's trying to use poll-task-urls...which if it's using the most recent version of generic-worker it should be using claimWork which does not require those scopes.  This leads me to believe that it's using the wrong version of g-w.
Flags: needinfo?(wcosta)
(In reply to Greg Arndt [:garndt] from comment #7)
> I think that machines repuppetized are having issues with scopes:
>   "message": "You do not have sufficient scopes. This request requires
> you\nto have one of the following sets of scopes:\n[\n  [\n   
> \"queue:poll-task-urls\",\n   
> \"assume:worker-type:releng-hardware/gecko-t-osx-\"\n  ],\n  [\n   
> \"queue:poll-task-urls:releng-hardware/gecko-t-osx-\"\n  ]\n]\n\nYou only
> have the scopes:\n[\n  \"assume:worker-id:*\",\n 
> \"assume:worker-type:scl3-puppet/os-x-*\",\n 
> \"auth:sentry:generic-worker\",\n  \"auth:statsum:generic-worker\",\n 
> \"queue:claim-task\",\n  \"queue:claim-work:scl3-puppet/*\",\n 
> \"queue:create-artifact:*\",\n  \"queue:pending-tasks:scl3-puppet/*\",\n 
> \"queue:poll-task-urls\",\n  \"queue:resolve-task\",\n 
> \"queue:worker-id:*\"\n]\n\nIn other words you are missing scopes from one
> of the options:\n * Option 0:\n    -
> \"assume:worker-type:releng-hardware/gecko-t-osx-\"\n * Option 1:\n    -
> \"queue:poll-task-urls:releng-hardware/gecko-t-osx-\"\n----\nmethod:    
> pollTaskUrls\nerrorCode:  InsufficientScopes\nstatusCode: 403\ntime:      
> 2017-06-01T03:33:42.468Z",
> 
> note the worker type it's trying to use "gecko-t-osx-" rather than something
> like "gecko-t-osx-1010"
> 
> Also, once that's fixed, the client ID being used for these machines needs
> the scopes for that new provisioner ID and worker type.
> 
> Side note: I see that it's trying to use poll-task-urls...which if it's
> using the most recent version of generic-worker it should be using claimWork
> which does not require those scopes.  This leads me to believe that it's
> using the wrong version of g-w.

Things are green now. Going to land the gecko side of this bug.
Flags: needinfo?(wcosta)
Comment on attachment 8872744 [details]
Bug 1368718: rename worker type.

https://reviewboard.mozilla.org/r/144268/#review148952

Still r+ with that change.

::: taskcluster/taskgraph/transforms/tests.py:701
(Diff revision 5)
>          # during the taskcluuster migration, this is a bit tortured, but it
>          # will get simpler eventually!
>          test_platform = test['test-platform']
>          if test_platform.startswith('macosx'):
>              # note that some portion of these will be allocated to BBB below
> -            test['worker-type'] = 'tc-worker-provisioner/gecko-t-osx-10-10'
> +            test['worker-type'] = WINDOWS_WORKER_TYPES['macosx64']

Can you use a separate `MACOSX_WORKER_TYPES`?
https://hg.mozilla.org/mozilla-central/rev/45cc52be6f78
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.