Provide a way for users to deny permission prompts by default in about:preferences

ASSIGNED
Assigned to

Status

()

Firefox
Preferences
ASSIGNED
7 months ago
17 hours ago

People

(Reporter: asa, Assigned: prathiksha)

Tracking

(Blocks: 2 bugs)

unspecified
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 wontfix, firefox58 affected)

Details

Attachments

(1 attachment)

(Reporter)

Description

7 months ago
Many users do not want push notifications and do not want to be prompted by so many websites to enable push notifications. Please provide a global "disable" option for all push notification prompts.
Tina, what do you think about adding a general way to disable the notification prompts entirely in about:preferences?
Flags: needinfo?(thsieh)
Yes, we can add that. Unlike other permissions (such as camera and microphone), blocking notifications won't disable any crucial functions on websites. I'll update the preferences permission spec later :)

Updated

5 months ago
Duplicate of this bug: 1313939
Depends on: 1379560
Let's make this bug track the frontend implementation, we'll solve denying the permission globally in bug 1379560.

Tina, do you have the updated spec ready? :)
There have been discussions about Push-specific mitigations in bug 1375683.
See Also: → bug 1375683
Thanks Andrew for sharing more context!

Hey Johann,
Sorry, the spec is still work in progress. The Photon Preferences redesign work is my first priority, so I'll focus on it now and come back to this bug when the Photon redesign is ready.
Blocks: 1375683
See Also: bug 1375683
Hi Johann,
Thanks for the waiting. Here is the updated spec with the globally disable notification prompts feature: https://mozilla.invisionapp.com/share/YHBWV6DP8#/243080171_5-7-2_Notifications_Global_Disable

The copy string is currently waiting for a review from our copy writer. I'll update the string here once we have a recommendation. Feel free to ping me if you have any questions :)

Tina
Flags: needinfo?(thsieh)
Core:Permission Manager sounds a better fit for this issue. Do feel free to reset. :)

Updated

5 months ago
Component: DOM: Push Notifications → Permission Manager
Duplicate of this bug: 1390783
Let's move this to preferences since the platform work landed in bug 1379560 and we should use this to track putting the deny checkbox into the permission dialog.

Prathiksha, we still have to figure out whether we want to extend this functionality to e.g. Geolocation (bug 1390782) and WebRTC, but we definitely need it for notifications.

Would you like to start implementing a checkbox as shown in comment 7?

Thank you!
Component: Permission Manager → Preferences
Flags: needinfo?(prathikshaprasadsuman)
Product: Core → Firefox
status-firefox57: --- → wontfix
status-firefox58: --- → affected
See Also: → bug 1390782
(Assignee)

Comment 11

2 months ago
(In reply to Johann Hofmann [:johannh] from comment #10) 
> Prathiksha, we still have to figure out whether we want to extend this
> functionality to e.g. Geolocation (bug 1390782) and WebRTC, but we
> definitely need it for notifications.
>
> Would you like to start implementing a checkbox as shown in comment 7?

yes. :)
Flags: needinfo?(prathikshaprasadsuman)
(Assignee)

Updated

2 months ago
Assignee: nobody → prathikshaprasadsuman
Status: NEW → ASSIGNED
We had a meeting on this and decided to add the proposed toggle to all of Notifications, Geolocation, Camera, and Microphone. I'm adjusting the bug title based on that.

We also said that we'd like to add a modal dialog having the user confirm that they're okay with the potential consequences of their action (breaking websites that rely on this functionality).

Jacqueline, can you help us come up with some copy for these four modal warnings? Let me know if you need help with that.

Thank you!
Flags: needinfo?(jsavory)
Summary: Provide a global "disable all push notifications" preference → Provide a way for users to deny permission prompts by default in about:preferences
Blocks: 1411700
(Assignee)

Comment 13

a month ago
We need updated specs to implement all things mentioned in comment 12 and get it into Firefox 58. Tina, can you provide us with the right checkbox and alert box strings, please ? :)

Thanks.
Flags: needinfo?(thsieh)
Created attachment 8925722 [details]
BlockingPermissions.png

Apologizes for the late response! I’m unfortunately a little too busy at the moment :) 

After some thought, the warning modal feels a bit overkill in this instance. I think we want to reserve those for really extreme situations and I’m not sure if this qualifies. Instead I think we should add additional information on the checkbox, to hopefully ensure that users are aware of the action they are taking. I’ve attached an image for what I mean, we can certainly adjust the copy. 

Also, I remember we discussed having a method for the user to disable or at least see that the permission is blocked in context. I can’t remember the consensus but I suggest we display it at least in control center, if not the URL bar as well. Ideally this would show only for sites that ask the permission, it might be easier to treat them as a “blocked” state rather than a “hidden” state.

Tina, I’d love to hear your feedback as well, I was also wondering about the string in your original spec, the “Never ask for sending notifications” I tweaked it a bit in my image, let me know what you think.
Flags: needinfo?(jsavory)
Hi Jacqueline,
I like the caption that tells more about how the option works, but I think we also need to let users know that the option may break some websites due to the permission is globally switched off. If we can have a set of clear copy that tells 1) This is a global switch 2) If you turn it off, it may break your browsing experience, then I'll be happy with not having a modal prompt for it.:)

I'll ping Michelle for her input here.
Flags: needinfo?(thsieh) → needinfo?(mheubusch)

Comment 16

a month ago
@Jacqueline - Can you arrange a meeting to discuss this with me and Tina? I'm not sure I see the connection between the issue and the proposed copy in the prefs or understand what the option does - block the request for new permissions or block all [prompts, even those currently permitted.  Thing we should also discuss this copy in context of what appears in the control center.
Flags: needinfo?(mheubusch) → needinfo?(jsavory)
(In reply to mheubusch from comment #16)
> block the request for new
> permissions or block all [prompts, even those currently permitted.

The former.
Michelle, Jacqueline, did this meeting happen and did anything valuable come out of it? I'd love to get this bug into 59...
Flags: needinfo?(mheubusch)
(In reply to Johann Hofmann [:johannh] from comment #18)
> Michelle, Jacqueline, did this meeting happen and did anything valuable come
> out of it? I'd love to get this bug into 59...

Reading this again it sounded a bit brash, it wasn't meant to, thank you for helping us with this :)

Comment 20

12 days ago
Jacqueline - Here are two options for the instructional copy (one with the modal, one without - both to address Tina's concern about messaging the potential for breakage):

These websites have requested permission to send notifications. You can specify which sites are allowed to send notifications. You can also block new requests to allow notifications. 


( ) Block new requests to allow notifications
This will prevent any websites not listed above from requesting permission to send notifications, and may affect website performance.

OR 

These websites have requested permission to send notifications. You can specify which sites are allowed to send notifications. You can also block new requests to allow notifications. 


( )Block new requests to allow notifications
This will prevent any websites not listed above from requesting permission to send notifications.

(modal): Blocking notifications may break some website features. OK | CANCEL
Flags: needinfo?(thsieh)
Flags: needinfo?(mheubusch)
Flags: needinfo?(jsavory)
Thank you very much! This copy sounds great to me. I don't think website performance will be affected negatively by blocking permissions, so we can probably leave that part out (unless I'm missing something).

Personally I'd say we should consider not adding a modal until we know from user feedback that too many people are enabling it unaware of the breakage. I wonder if we should just append the modal text to the checkbox information:

( )Block new requests to allow notifications
This will prevent any websites not listed above from requesting permission to send notifications. Blocking notifications may break some website features.

or

( )Block new requests to allow notifications
This will prevent any websites not listed above from requesting permission to send notifications and may break some website features.

Any thoughts?
Agree with Johann that we can tell the possible breaking issues by adding a description under the option without using a modal dialog. For the copy suggestion, I personally think they both work.

Let's see how Michelle think about it :)
Flags: needinfo?(thsieh)

Comment 23

11 days ago
My vote: ( )Block new requests to allow notifications
This will prevent any websites not listed above from requesting permission to send notifications. Blocking notifications may break some website features.


thanks, all!
Duplicate of this bug: 1423402

Comment 25

5 days ago
I love the implementation mock up in comment 14. Thanks for your hard work!
You need to log in before you can comment on or make changes to this bug.