If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Respect Windows 10 Dark / Light color settings

NEW
Unassigned

Status

()

Firefox
Theme
P3
major
5 months ago
8 hours ago

People

(Reporter: gcp, Unassigned)

Tracking

(Depends on: 1 bug)

Trunk
x86_64
Windows 10
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify +

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

5 months ago
Windows 10, current Nightly

After bug 1367384 the Firefox titlebar looks wrong and alien compared to every other Windows application. All other apps use light grey or white, and Firefox is dark grey/black.

After some fiddling in Windows, I found Settings->Color->More Options->Choose Default App Mode

This is currently set to "Light". I think this is the default - I don't remember changing it.

When I set this to "Dark", Windows' own windows and other software such as Edge uses a dark titlebar, close but not exactly the same as Firefox. It looks like this setting is what the Firefox design was intended to match.

But when it is set to "Light", Firefox is, incorrectly, Dark.
(Reporter)

Updated

5 months ago
Blocks: 1367384

Updated

5 months ago
Whiteboard: [photon-visual][triage]

Comment 1

5 months ago
The title bar is intended to be dark by default, which IMHO is a great default (making Firefox match Windows settings for Light/Dark modes is reported already as bug 1176577). And you can’t really argue that one app should abide to “all other apps”* in Windows 10 — any app, especially if it’s UWP, can color its title bar differently to the rest: the MSN apps News and Money, for example, use very vivid colors instead of the default white. IMHO, this bug is invalid.

* By “all other apps”, I suspect, you’re referring to legacy Win32 programs, not something to follow when it comes to design in Windows 10…
Status: NEW → UNCONFIRMED
Ever confirmed: false

Comment 2

4 months ago
This is working as designed, but we'll likely get a good amount of similar complaints. Stephen, can you please comment / resolve as appropriate? Thanks.
Flags: needinfo?(shorlander)
(Reporter)

Comment 3

4 months ago
Bug 1176577 is now rather amusing, and I think the switch referred to in it is now exposed in Windows 10.

What are you going to do when the user selects the dark theme? Make the titlebar white?

>And you can’t really argue that one app should abide to “all other apps”* in Windows 10

I think I can argue that if I select a light theme, I expect a light theme.

Comment 4

4 months ago
(In reply to Gian-Carlo Pascutto [:gcp] from comment #3)
> Bug 1176577 is now rather amusing, and I think the switch referred to in it
> is now exposed in Windows 10.
> 
> What are you going to do when the user selects the dark theme? Make the
> titlebar white?

No.

> >And you can’t really argue that one app should abide to “all other apps”* in Windows 10
> 
> I think I can argue that if I select a light theme, I expect a light theme.

The thing is that light is the default, so we can't necessarily infer user intent from that.

Updated

4 months ago
Flags: qe-verify+
Priority: -- → P2
QA Contact: brindusa.tot
Whiteboard: [photon-visual][triage] → [photon-visual]

Comment 5

4 months ago
I've never really understood the need for per-application theming, Luddite that I am...

Firefox Nightly offers me three built-in themes: "Default", "Light" and "Dark".  But I don't want application-specific theming - I want my platform look-n-feel.  Hm.  I choose "Default" in the hope that's what that means: unthemed.  But no, it's not: rather than "default" looking through to the platform to create itself (tricky, I guess), it's still just a preset like the others - sort of half-n-half dark and light.  Dark menu bar, light toolbar...

Screen shots are available in bug 1369884 but I guess everyone knows this.
We could respect the system Dark / Light settings, like we do for picking up the Title Bar color system setting, but probably not for 57. I think there might even be a bug about that already?

What we have now are essentially four settings:

+-------------------+
|Automatic          |
+-------------------+
|Light on Dark      |
+-------------------+
|Light              |
+-------------------+
|Dark               |
+-------------------+

Automatic being the out of the box setting that defaults to Light on Dark, but that respects some system settings like Title Bar accent color and High Contrast mode.

We only list three options now though: Default, Light and Dark

I think should just make it more explicit and add Automatic as the default and selecting another option would override that.
Flags: needinfo?(shorlander)

Comment 7

3 months ago
(In reply to Stephen Horlander [:shorlander] from comment #6)
> We could respect the system Dark / Light settings, like we do for picking up
> the Title Bar color system setting, but probably not for 57.

Okay, moving this to the reserve.

> I think there might even be a bug about that already?

Bug 1176577.
Depends on: 1176577
Priority: P2 → P3
Whiteboard: [photon-visual] → [reserve-photon-visual][p3]
Summary: Title bar is themed dark despite "Light" Colors setting → Respect Windows 10 Dark / Light color settings
Status: UNCONFIRMED → NEW
Ever confirmed: true

Updated

2 months ago
Whiteboard: [reserve-photon-visual][p3] → [reserve-photon-visual][p3][high-priority]

Updated

2 months ago
Priority: P3 → P4

Updated

8 hours ago
Priority: P4 → P3
Whiteboard: [reserve-photon-visual][p3][high-priority]
You need to log in before you can comment on or make changes to this bug.