Closed
Bug 1368843
Opened 7 years ago
Closed 6 years ago
libaom doesn't build for android
Categories
(Core :: Audio/Video: Playback, enhancement, P3)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: rillian, Assigned: TD-Linux)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
The libaom (av1 reference implementation) code doesn't build on arm-linux-android. Like with libvpx, it has some arm assembly we have to convert to an llvm-assembler-acceptable format before we can pass it to the compiler. We could add support for this in a Makefile.in (like libvpx) or by adding hooks to mozbuild's GENERATED_FILES object. However, upstream has indicated that they'd like to move away from assembly in favour of compiler intrinsics for neon, since portability of those has improved to a useful state. I've done some work toward removing the assembly entirely upstream but some functions still need to be converted. So this is a little more work, but nicer going forward.
Updated•7 years ago
|
Priority: -- → P3
Updated•6 years ago
|
Rank: 25
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → tdaede
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f61e8f85cf8ffbf1850df098eed3d17d82a92074
Comment 3•6 years ago
|
||
Comment on attachment 9010464 [details] Bug 1368843: Enable libaom on Android. r=jya Jean-Yves Avenard [:jya] has approved the revision.
Attachment #9010464 -
Flags: review+
Pushed by tdaede@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ea436a9177b5 Enable libaom on Android. r=jya
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ea436a9177b5
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•