Closed Bug 1368850 Opened 3 years ago Closed 3 years ago

MP4Metadata.cpp:1030:11: warning: enumeration value 'mp4parse_codec_MP4V' not handled in switch

Categories

(Core :: Audio/Video: Playback, defect)

55 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: gerald, Assigned: ayang)

References

Details

Attachments

(1 file)

Bug 1363669 introduced a new mp4parse_codec enum value mp4parse_codec_MP4V, but it is not handled in the `switch (info.codec)` in MP4Metadata.cpp:

> In file included from media/libstagefright/Unified_cpp_media_libstagefright0.cpp:74:
> media/libstagefright/binding/MP4Metadata.cpp:1030:11: warning: enumeration value 'mp4parse_codec_MP4V' not handled in switch [-Wswitch]
>   switch (info.codec) {
>           ^
Oop...
Assignee: nobody → ayang
Comment on attachment 8872889 [details]
Bug 1368850 - fix warning message about enumeration value 'mp4parse_codec_MP4V' not handled.

https://reviewboard.mozilla.org/r/144412/#review148238

Great, thank you for fixing this quickly.
Attachment #8872889 - Flags: review?(gsquelart) → review+
Pushed by ayang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e1d2707ee01d
fix warning message about enumeration value 'mp4parse_codec_MP4V' not handled. r=gerald
https://hg.mozilla.org/mozilla-central/rev/e1d2707ee01d
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.