Closed Bug 1368866 Opened 3 years ago Closed 3 years ago

Clicking during window.requestAnimationFrame() loop kills the rendering performance when APZ is enabled

Categories

(Core :: Panning and Zooming, defect, P3)

53 Branch
defect

Tracking

()

RESOLVED WONTFIX
Tracking Status
firefox53 --- wontfix
firefox54 --- wontfix
firefox55 --- affected

People

(Reporter: miko, Unassigned)

References

Details

(Keywords: regression, testcase, Whiteboard: [gfx-noted])

Attachments

(1 file)

Attached file testcase
Clicking during window.requestAnimationFrame() loop increases DL, FLB, and rasterizing time by 3-4x, when APZ is enabled. Disabling APZ will make the problem go away.

Steps to reproduce: Open the testcase and click anywhere in the window. The performance hit should be obvious.

Reproduced on FF53 and Nightly, on OSX and Windows 10.

Profile: https://perfht.ml/2rCIl7I (clicked at around t=3.4)

Regression window: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=dd1abe874252e507b825a0a4e1063b0e13578288&tochange=946ed22cad04431c75ab5093989dfedf1bae5a3e
Kats: The regression range includes bug 1242690, which might be related. Could you please take a look?
Flags: needinfo?(bugmail)
Whiteboard: [gfx-note]
Whiteboard: [gfx-note] → [gfx-noted]
If I follow the STR with apz.minimap.enabled=true, I can see the displayport expands on clicking, so that explains the slowdown in paint time. The displayport expanding is more or less expected behaviour - we keep it small initially for faster initial page load but as soon as you start scrolling (or apparently even if you click on the document) the displayport will expand to the "full" size that we use during steady state.

The alternative here is to find a way to keep the displayport small during a click - but it will still expand as soon as the user starts scrolling. I'm not sure how useful it would be to make this change - it seems a bit artificial unless this is reduced from a real-world test case?
Flags: needinfo?(bugmail)
ni for the question at the end of comment 2 ^
Flags: needinfo?(mikokm)
OS: Unspecified → All
Priority: -- → P3
Hardware: Unspecified → All
Version: unspecified → 53 Branch
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #3)
> ni for the question at the end of comment 2 ^

Thanks for the feedback. We are using this testcase for display list building benchmarking, so it is not from a real-world test case.
Flags: needinfo?(mikokm)
Resolving as WONTFIX as per comment 2.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.