1368899 - Switch JSON Viewer back to standards mode

Status: RESOLVED FIXED

(DevTools :: JSON Viewer, defect, P3)

Description

[Oriol Brufau [:Oriol]]

Attachment: json-stream-v2.patch

Bug 1367894 fixed various things but switched JSON Viewer to quirks mode and loaded the stylesheets at the end. This patch addresses these problems.

Now it works like this:
 1. The content type is set to text/html
 2. A doctype, the stylesheet and the script are sent at the very beginning
 3. A <plaintext> start tag switches the tokenizer to plaintext state
 4. The chunks of JSON are then directly sent unaltered to the page when they are received

To keep the HTML simple, I only linked the main stylesheet and made it import the other ones. reps.css is already imported by tree-view.css, so no need to import it from main.css

To avoid problems like bug 1260189, I moved all the initialization code to onStartRequest (previously some work was done in onStopRequest), and deferred the script.

Then onStartRequest became too cluttered so I moved code to helper functions.

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8872860 [details] [diff] [review]
json-stream-v2.patch

Review of attachment 8872860 [details] [diff] [review]:
-----------------------------------------------------------------

Looks reasonable.

R+ assuming Try is green.

Thanks for working on this!

Honza

Comment 2

[Oriol Brufau [:Oriol]]

Can you post the Try link to see if it's green?

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Try push here:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=40ab47ec30fb5bf5dd08caa2abb163594a9b6dac
(in progress atm)

Honza

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d284663f05d
Refactor the JSON Viewer stream converter to avoid quirks mode. r=Honza

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1d284663f05d