Closed
Bug 1368937
Opened 7 years ago
Closed 7 years ago
Make search event opt-out
Categories
(Toolkit :: Telemetry, enhancement, P1)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: gfritzsche, Assigned: gfritzsche)
Details
Attachments
(1 file)
1.35 KB,
patch
|
Dexter
:
review+
rweiss
:
feedback+
|
Details | Diff | Splinter Review |
For it to be useful, we should make the search event opt-out: https://dxr.mozilla.org/mozilla-central/rev/39d5cc0fda5e16c49a59d29d4ca186a5534cc88b/toolkit/components/telemetry/Events.yaml#2 Currently all event recording requires explicit activation/enabling by an add-on anyway, so making this opt-out poses no increased risk.
Assignee | ||
Comment 1•7 years ago
|
||
Make search event opt-out & and add David Zeber to the owners.
Attachment #8872885 -
Flags: review?(alessio.placitelli)
Comment 2•7 years ago
|
||
Comment on attachment 8872885 [details] [diff] [review] Make search event opt-out Review of attachment 8872885 [details] [diff] [review]: ----------------------------------------------------------------- This looks technically ok: do you also need a data-review from someone else since we're making this opt-out?
Attachment #8872885 -
Flags: review?(alessio.placitelli) → review+
Assignee | ||
Comment 3•7 years ago
|
||
Comment on attachment 8872885 [details] [diff] [review] Make search event opt-out Rebecca, i'm requesting data review for this smaller change to make the search event opt-out. David Zeber signed up as the owner / monitoring user. Events are currently mainly accessible through a re:dash table & custom analysis. This is a low risk change as this does not directly enable event recording. To enable this event, add-ons (say studies or experiments) still need to explicitly enable event recording for each session, as i outlined in [0] & [1]. For the search event to be really useful to any search experiments or studies, we need to make it opt-out though. Otherwise we will only be able to get search event data from Telemetry opt-in users on release. 0: https://docs.google.com/presentation/d/14EcnTIz1jP5N3sst8IVYr99UjT-PsnjC3BaVKi6H7Is/edit#slide=id.g1f0eee911f_1_90 1: https://gecko.readthedocs.io/en/latest/toolkit/components/telemetry/telemetry/collection/events.html#the-api
Attachment #8872885 -
Flags: feedback?(rweiss)
Comment 4•7 years ago
|
||
This strikes me as type 2 data collection. For posterity, what dataset will these events be added to? main_summary/longitudinal? r+ given these details.
Updated•7 years ago
|
Attachment #8872885 -
Flags: feedback?(rweiss) → feedback+
Assignee | ||
Comment 5•7 years ago
|
||
(In reply to Rebecca Weiss from comment #4) > For posterity, what dataset will these events be added to? > main_summary/longitudinal? The event data will show up in "main_summary" and the "events" dataset.
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/mozilla-inbound/rev/c18268020e6e Make search event opt-out. r=Dexter data-review=rweiss
Keywords: checkin-needed
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c18268020e6e
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•