All users were logged out of Bugzilla on October 13th, 2018

Make search event opt-out

RESOLVED FIXED in Firefox 55

Status

()

P1
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: gfritzsche, Assigned: gfritzsche)

Tracking

Trunk
mozilla55
Points:
1

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
For it to be useful, we should make the search event opt-out:
https://dxr.mozilla.org/mozilla-central/rev/39d5cc0fda5e16c49a59d29d4ca186a5534cc88b/toolkit/components/telemetry/Events.yaml#2

Currently all event recording requires explicit activation/enabling by an add-on anyway, so making this opt-out poses no increased risk.
(Assignee)

Comment 1

a year ago
Created attachment 8872885 [details] [diff] [review]
Make search event opt-out

Make search event opt-out & and add David Zeber to the owners.
Attachment #8872885 - Flags: review?(alessio.placitelli)
Comment on attachment 8872885 [details] [diff] [review]
Make search event opt-out

Review of attachment 8872885 [details] [diff] [review]:
-----------------------------------------------------------------

This looks technically ok: do you also need a data-review from someone else since we're making this opt-out?
Attachment #8872885 - Flags: review?(alessio.placitelli) → review+
(Assignee)

Comment 3

a year ago
Comment on attachment 8872885 [details] [diff] [review]
Make search event opt-out

Rebecca, i'm requesting data review for this smaller change to make the search event opt-out.

David Zeber signed up as the owner / monitoring user.
Events are currently mainly accessible through a re:dash table & custom analysis.

This is a low risk change as this does not directly enable event recording.
To enable this event, add-ons (say studies or experiments) still need to explicitly enable event recording for each session, as i outlined in [0] & [1].

For the search event to be really useful to any search experiments or studies, we need to make it opt-out though.
Otherwise we will only be able to get search event data from Telemetry opt-in users on release.

0: https://docs.google.com/presentation/d/14EcnTIz1jP5N3sst8IVYr99UjT-PsnjC3BaVKi6H7Is/edit#slide=id.g1f0eee911f_1_90
1: https://gecko.readthedocs.io/en/latest/toolkit/components/telemetry/telemetry/collection/events.html#the-api
Attachment #8872885 - Flags: feedback?(rweiss)

Comment 4

a year ago
This strikes me as type 2 data collection. 

For posterity, what dataset will these events be added to?  main_summary/longitudinal?

r+ given these details.

Updated

a year ago
Attachment #8872885 - Flags: feedback?(rweiss) → feedback+
(Assignee)

Comment 5

a year ago
(In reply to Rebecca Weiss from comment #4)
> For posterity, what dataset will these events be added to? 
> main_summary/longitudinal?

The event data will show up in "main_summary" and the "events" dataset.
(Assignee)

Updated

a year ago
Keywords: checkin-needed

Comment 6

a year ago
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c18268020e6e
Make search event opt-out. r=Dexter data-review=rweiss
Keywords: checkin-needed

Comment 7

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c18268020e6e
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.