1368940 - Potential race condition in adjustTabstrip

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, enhancement)

Description

[Dão Gottwald [:dao]]

See bug 1368208 comment 44. adjustTabstrip is using basically the same pattern as _updateScrollButtonsDisabledState.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1368940 - Avoid potential race condition in adjustTabstrip.

The early this.getAttribute("overflow") == "true" check + requestAnimationFrame + _closeButtonsUpdatePending can make us skip an adjustTabstrip call from the overflow event that would remove the overflow attribute.

Review commit: https://reviewboard.mozilla.org/r/144400/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/144400/

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8872884 [details]
Bug 1368940 - Avoid potential race condition in adjustTabstrip.

https://reviewboard.mozilla.org/r/144400/#review148330

Seems okay. Thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82c13bf36119
Avoid potential race condition in adjustTabstrip. r=mconley

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/82c13bf36119