If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

store-failure-lines "UnboundLocalError: local variable 'failure_lines' referenced before assignment"

RESOLVED FIXED

Status

Tree Management
Treeherder: Data Ingestion
P1
normal
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: emorley, Assigned: jgraham)

Tracking

(Blocks: 1 bug)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 months ago
James, could you take a look?

https://rpm.newrelic.com/accounts/677903/applications/14179757/filterable_errors?tw%5Bend%5D=1496229073&tw%5Bstart%5D=1495624273#/show/95ef8417-41d3-11e7-931c-0242ac110012_0_4802/stack_trace?top_facet=transactionUiName&primary_facet=error.class&barchart=barchart&_k=nm1xtq
Flags: needinfo?(james)

Comment 1

4 months ago
Created attachment 8872975 [details] [review]
[treeherder] mozilla:failure_line_error > mozilla:master

Comment 2

4 months ago
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/0fc556cc647b2493d99d9c806fdf2330315345f4
Bug 1368988 - OperationalError ignored during failure_line storage.

This code assumes that any caught error results in a retry. But
that isn't actaully true for OperationalError where we only want
to retry if it's a specific kind of error, and otherwise just raise.
(Reporter)

Comment 3

4 months ago
Many thanks for sorting this so quickly!
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
Flags: needinfo?(james)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.