Closed
Bug 1368994
Opened 7 years ago
Closed 7 years ago
remove WARNING: '!compMgr', file xpcom/components/nsComponentManagerUtils.cpp, line 63
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: mayhemer, Assigned: erahm)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
1.39 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
We live with this for years.
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8890433 -
Flags: review?(nfroyd)
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Comment 2•7 years ago
|
||
Comment on attachment 8890433 [details] [diff] [review] Remove !compMgr warning Review of attachment 8890433 [details] [diff] [review]: ----------------------------------------------------------------- In a perfect world, it would be nice if we could warn the first time you tried to get a particular service after the compMgr went away (and tell you what the service was, so maybe you could fix it), but I suppose that would be a hugeish patch, wouldn't it?
Attachment #8890433 -
Flags: review?(nfroyd) → review+
Assignee | ||
Comment 3•7 years ago
|
||
(In reply to Nathan Froyd [:froydnj] from comment #2) > Comment on attachment 8890433 [details] [diff] [review] > Remove !compMgr warning > > Review of attachment 8890433 [details] [diff] [review]: > ----------------------------------------------------------------- > > In a perfect world, it would be nice if we could warn the first time you > tried to get a particular service after the compMgr went away (and tell you > what the service was, so maybe you could fix it), but I suppose that would > be a hugeish patch, wouldn't it? It's a lot simpler to use a call to GetService failing as an indicator to stop doing stuff than to figure out all the stuff we're doing and preemptively stop it. Given the volume of the warning I think we've lost this battle.
Assignee | ||
Comment 4•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/0a667bf8c1a72692512122bedb41be805a4a19f1 Bug 1368994 - Remove !compMgr warning. r=froydnj
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0a667bf8c1a7
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•