1368994 - remove WARNING: '!compMgr', file xpcom/components/nsComponentManagerUtils.cpp, line 63

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Honza Bambas (:mayhemer)]

We live with this for years.

Comment 1

[Eric Rahm [:erahm]]

Attachment: Remove !compMgr warning

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8890433 [details] [diff] [review]
Remove !compMgr warning

Review of attachment 8890433 [details] [diff] [review]:
-----------------------------------------------------------------

In a perfect world, it would be nice if we could warn the first time you tried to get a particular service after the compMgr went away (and tell you what the service was, so maybe you could fix it), but I suppose that would be a hugeish patch, wouldn't it?

Comment 3

[Eric Rahm [:erahm]]

(In reply to Nathan Froyd [:froydnj] from comment #2)
> Comment on attachment 8890433 [details] [diff] [review]
> Remove !compMgr warning
> 
> Review of attachment 8890433 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> In a perfect world, it would be nice if we could warn the first time you
> tried to get a particular service after the compMgr went away (and tell you
> what the service was, so maybe you could fix it), but I suppose that would
> be a hugeish patch, wouldn't it?

It's a lot simpler to use a call to GetService failing as an indicator to stop doing stuff than to figure out all the stuff we're doing and preemptively stop it. Given the volume of the warning I think we've lost this battle.

Comment 4

[Eric Rahm [:erahm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0a667bf8c1a72692512122bedb41be805a4a19f1
Bug 1368994 - Remove !compMgr warning. r=froydnj

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0a667bf8c1a7