Closed Bug 1369009 Opened 4 years ago Closed 3 years ago

Intermittent layout/style/test/browser_newtab_share_rule_processors.js | application crashed [@ mozilla::net::CacheIOThread::OnDispatchedEvent]

Categories

(Core :: Networking, defect)

defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox-esr52 --- unaffected
firefox54 --- unaffected
firefox55 --- wontfix
firefox56 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: michal)

Details

(Keywords: crash, intermittent-failure, Whiteboard: [necko-next])

Crash Data

Attachments

(1 file)

Flags: needinfo?(honzab.moz)
Hmm... there has been a timer scheduled to fire on the cache IO thread, but that time was not canceled before the cache IO thread shutdown.  No idea which timer this could be.  This is nothing critical to fix, if there is leak because of this it's probably not huge.  If the timer doesn't fire I don't believe anything major fails because of that.

I'll take this bug to look for timers that could be scheduled on the cache io thread and not properly canceled before it shuts down.

CC'ing michal for thoughts too.
Assignee: nobody → honzab.moz
Flags: needinfo?(honzab.moz)
Whiteboard: [necko-next]
Attached patch fixSplinter Review
This is probably mTrashTimer in CacheFileIOManager.
Assignee: honzab.moz → michal.novotny
Status: NEW → ASSIGNED
Attachment #8884274 - Flags: review?(honzab.moz)
Comment on attachment 8884274 [details] [diff] [review]
fix

Review of attachment 8884274 [details] [diff] [review]:
-----------------------------------------------------------------

That could be it, thanks.
Attachment #8884274 - Flags: review?(honzab.moz) → review+
Keywords: checkin-needed
Please try to use commit messages which explain what the patch is actually doing rather than restating the problem being fixed in the future.
http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/commits.html#write-detailed-commit-messages
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/734640228fbc
Intermittent layout/style/test/browser_newtab_share_rule_processors.js. r=honzab
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/734640228fbc
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Doesn't look worth considering for Beta backport, but feel free to set the status back to affected and nominate for approval if you feel strongly otherwise.
You need to log in before you can comment on or make changes to this bug.