1369009 - Intermittent layout/style/test/browser_newtab_share_rule_processors.js | application crashed [@ mozilla::net::CacheIOThread::OnDispatchedEvent]

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Treeherder Bug Filer]

Filed by: cbook [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=103372189&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/FOQEost2RoafsgCBCaTgsQ/runs/0/artifacts/public/logs/live_backing.log

Comment 1

[Honza Bambas (:mayhemer)]

Hmm... there has been a timer scheduled to fire on the cache IO thread, but that time was not canceled before the cache IO thread shutdown.  No idea which timer this could be.  This is nothing critical to fix, if there is leak because of this it's probably not huge.  If the timer doesn't fire I don't believe anything major fails because of that.

I'll take this bug to look for timers that could be scheduled on the cache io thread and not properly canceled before it shuts down.

CC'ing michal for thoughts too.

Comment 2

[Michal Novotny [:michal]]

Attachment: fix

This is probably mTrashTimer in CacheFileIOManager.

Comment 3

[Honza Bambas (:mayhemer)]

Comment on attachment 8884274 [details] [diff] [review]
fix

Review of attachment 8884274 [details] [diff] [review]:
-----------------------------------------------------------------

That could be it, thanks.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Please try to use commit messages which explain what the patch is actually doing rather than restating the problem being fixed in the future.
http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/commits.html#write-detailed-commit-messages

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/734640228fbc
Intermittent layout/style/test/browser_newtab_share_rule_processors.js. r=honzab

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/734640228fbc

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Doesn't look worth considering for Beta backport, but feel free to set the status back to affected and nominate for approval if you feel strongly otherwise.