Closed Bug 136901 Opened 22 years ago Closed 21 years ago

toOpenWindowByType should never open multiple windows

Categories

(SeaMonkey :: UI Design, defect)

Product:
SeaMonkey
Component:
UI Design
Platform:
x86
Windows 95
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

References

Details

(Keywords: polish)

Attachments

(1 file, 1 obsolete file)

Updated for bitrot
4.27 KB, patch
janv
: review+
bzbarsky
: superreview+
Details | Diff | Splinter Review 
Currently bookmarks and history have to work around this.
Attached patch Proposed Patch (obsolete) — — Splinter Review 

    
  
Keywords: patch, 
          
            polish, 
          
            review

    
    

    
  
-> neil to drive checkin
Assignee: blaker → neil

    
    

    
  
*** Bug 158624 has been marked as a duplicate of this bug. ***

    
    

    
  
Bad luck Blake, I'm going on holiday until August so someone else will have to
do it instead.

    
  

        Attachment #78728 -
        Flags: superreview?(bzbarsky)

        Attachment #78728 -
        Flags: review?(blaker)

    
    

    
  
Comment on attachment 78728 [details] [diff] [review]
Proposed Patch

Um... Why is this using openDialog() exactly?  And what's up with the
indentation where toNewWindow() is called?

        Attachment #78728 -
        Flags: superreview?(bzbarsky) → superreview-

    
    

    
  


  
I had to incorporate the toNewWindow code because toOpenWindow only works on
loaded windows.

        Attachment #78728 -
        Attachment is obsolete: true

    
  

        Attachment #127239 -
        Flags: superreview?(bzbarsky)

        Attachment #127239 -
        Flags: review?(varga)

        Attachment #127239 -
        Flags: superreview?(bzbarsky) → superreview+

    
    

    
  
Comment on attachment 127239 [details] [diff] [review]
Updated for bitrot

this looks good

        Attachment #127239 -
        Flags: review?(varga) → review+

    
    

    
  
Fix checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 78728 [details] [diff] [review]
Proposed Patch

clearing review request for obsolete patch

        Attachment #78728 -
        Flags: review?(blakeross)
Product: Core → Mozilla Application Suite

    
  
Component: XP Apps: GUI Features → UI Design

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: