toOpenWindowByType should never open multiple windows

RESOLVED FIXED

Status

SeaMonkey
UI Design
RESOLVED FIXED
16 years ago
10 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: neil@parkwaycc.co.uk)

Tracking

({polish})

Trunk
x86
Windows 95
polish

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

16 years ago
Currently bookmarks and history have to work around this.
(Assignee)

Comment 1

16 years ago
Created attachment 78728 [details] [diff] [review]
Proposed Patch
(Assignee)

Updated

16 years ago
Keywords: patch, polish, review

Comment 2

16 years ago
-> neil to drive checkin
Assignee: blaker → neil
(Assignee)

Comment 3

16 years ago
*** Bug 158624 has been marked as a duplicate of this bug. ***
(Assignee)

Comment 4

16 years ago
Bad luck Blake, I'm going on holiday until August so someone else will have to
do it instead.
(Assignee)

Updated

15 years ago
Attachment #78728 - Flags: superreview?(bzbarsky)
Attachment #78728 - Flags: review?(blaker)
Comment on attachment 78728 [details] [diff] [review]
Proposed Patch

Um... Why is this using openDialog() exactly?  And what's up with the
indentation where toNewWindow() is called?
Attachment #78728 - Flags: superreview?(bzbarsky) → superreview-
(Assignee)

Comment 6

15 years ago
Created attachment 127239 [details] [diff] [review]
Updated for bitrot

I had to incorporate the toNewWindow code because toOpenWindow only works on
loaded windows.
Attachment #78728 - Attachment is obsolete: true
(Assignee)

Updated

15 years ago
Attachment #127239 - Flags: superreview?(bzbarsky)
Attachment #127239 - Flags: review?(varga)
Attachment #127239 - Flags: superreview?(bzbarsky) → superreview+

Comment 7

15 years ago
Comment on attachment 127239 [details] [diff] [review]
Updated for bitrot

this looks good
Attachment #127239 - Flags: review?(varga) → review+
(Assignee)

Comment 8

15 years ago
Fix checked in.
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
Comment on attachment 78728 [details] [diff] [review]
Proposed Patch

clearing review request for obsolete patch
Attachment #78728 - Flags: review?(blakeross)
Product: Core → Mozilla Application Suite

Updated

10 years ago
Component: XP Apps: GUI Features → UI Design
You need to log in before you can comment on or make changes to this bug.