1369012 - Don't show the one-off buttons if the only visible engine would be the current one

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P2)

Description

[Marco Bonardo [:mak]]

If only the current engine is checked for the one-off buttons, it doesn't make sense to show the one-offs bar, since its usefulness would be very low.

Currently we hide the one-offs bar only if 0 engines are enabled, mostly because the search bar doesn't show a one-off for the current engine, so there it makes totally sense. Not for the Location Bar though.

Comment 1

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

This is a P1 bug without an assignee. 

P1 are bugs which are being worked on for the current release cycle/iteration/sprint. 

If the bug is not assigned by Monday, 28 August, the bug's priority will be reset to '--'.

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Bug 1369012 - Don't show the one-off buttons if the only visible engine would be the current one

Review commit: https://reviewboard.mozilla.org/r/172928/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/172928/

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

There appears to be a bug where unchecking search engines from preferences doesn't update the list of visible engines. I wonder if this is fallout from the recent one-off caching work.

Comment 4

[Florian Quèze [:florian]]

(In reply to Panos Astithas [:past] (56 Regression Engineering Owner) (please ni?) from comment #3)
> There appears to be a bug where unchecking search engines from preferences
> doesn't update the list of visible engines. I wonder if this is fallout from
> the recent one-off caching work.

Do you have specific steps to reproduce? (I checked quickly and it seems to work for me)

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

The engines do get removed from the one-off row in the awesomebar, but running |Services.search.getVisibleEngines().length| in the browser console still shows 7.

Comment 6

[Florian Quèze [:florian]]

(In reply to Panos Astithas [:past] (56 Regression Engineering Owner) (please ni?) from comment #5)
> The engines do get removed from the one-off row in the awesomebar, but
> running |Services.search.getVisibleEngines().length| in the browser console
> still shows 7.

getVisibleEngines is the list of engines visible in the preferences, not the list of engines visible as one-off (the latter is getVisibleEngines() minus the engines listed in the browser.search.hiddenOneOffs pref).

The reason why we need to have getVisibleEngines is that built-in engines are non removable, so when a user removes one from the preferences, the engine is just hidden.

Comment 7

[Marco Bonardo [:mak]]

stealing, I have a patch for this and bug 1416041, I'm trying to add some kind of test for it.

Comment 8

[Marco Bonardo [:mak]]

fixed by bug 1416041