Closed Bug 1369073 Opened 3 years ago Closed 3 years ago

MessagePort/MessageChannel should be testable using to xpcshell tests

Categories

(Core :: XPConnect, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: baku, Assigned: baku)

Details

Attachments

(1 file)

I probably need to implement some xpcshell tests for IPCBlob. The easiest way for having an IPCBlob is to use MessagePort or BroadcastChannel because these APIs use PBackground also on the parent process.
Attachment #8873072 - Flags: review?(bobbyholley)
Comment on attachment 8873072 [details] [diff] [review]
messagePort.patch

Review of attachment 8873072 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with that.

::: js/xpconnect/tests/unit/test_messageChannel.js
@@ +1,4 @@
> +/* Any copyright is dedicated to the Public Domain.
> + * http://creativecommons.org/publicdomain/zero/1.0/ */
> +
> +function run_test() {

Please add some actual tests for the functionality here, rather than just verifying the existence of the constructors.
Attachment #8873072 - Flags: review?(bobbyholley) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/313abe9e730e
Expose MessagePort/MessageChannel to xpcshell tests, r=bholley
https://hg.mozilla.org/mozilla-central/rev/313abe9e730e
Status: NEW → RESOLVED
Closed: 3 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.